[epiphany/wip/sync: 2/4] synchronizable-manager: Change _add() to be (transfer none)



commit b083ba5264567d347d6ce42676d45cb2edf69dc0
Author: Gabriel Ivascu <ivascu gabriel59 gmail com>
Date:   Sun Apr 2 21:52:51 2017 +0300

    synchronizable-manager: Change _add() to be (transfer none)

 src/bookmarks/ephy-bookmarks-manager.c |    1 -
 src/sync/ephy-sync-service.c           |    3 +--
 src/sync/ephy-synchronizable-manager.c |    2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/src/bookmarks/ephy-bookmarks-manager.c b/src/bookmarks/ephy-bookmarks-manager.c
index bf30838..97bf7b1 100644
--- a/src/bookmarks/ephy-bookmarks-manager.c
+++ b/src/bookmarks/ephy-bookmarks-manager.c
@@ -295,7 +295,6 @@ synchronizable_manager_add (EphySynchronizableManager *manager,
 
   ephy_bookmarks_manager_add_bookmark (self, bookmark);
   ephy_bookmarks_manager_create_tags_from_bookmark (self, bookmark);
-  g_object_unref (bookmark);
 }
 
 static void
diff --git a/src/sync/ephy-sync-service.c b/src/sync/ephy-sync-service.c
index 40799ed..ff86120 100644
--- a/src/sync/ephy-sync-service.c
+++ b/src/sync/ephy-sync-service.c
@@ -1306,10 +1306,9 @@ download_synchronizable_cb (SoupSession *session,
   if (!is_deleted) {
     ephy_synchronizable_manager_add (data->manager, synchronizable);
     LOG ("Successfully downloaded from server");
-  } else {
-    g_object_unref (synchronizable);
   }
 
+  g_object_unref (synchronizable);
 free_parser:
   g_object_unref (parser);
 out:
diff --git a/src/sync/ephy-synchronizable-manager.c b/src/sync/ephy-synchronizable-manager.c
index b7e5a4e..f110587 100644
--- a/src/sync/ephy-synchronizable-manager.c
+++ b/src/sync/ephy-synchronizable-manager.c
@@ -157,7 +157,7 @@ ephy_synchronizable_manager_set_sync_time (EphySynchronizableManager *manager,
 /**
  * ephy_synchronizable_manager_add:
  * @manager: an #EphySynchronizableManager
- * @synchronizable: (transfer full): an #EphySynchronizable
+ * @synchronizable: (transfer none): an #EphySynchronizable
  *
  * Adds @synchronizable to the local instance of the collection managed by @manager.
  **/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]