[gnome-todo] window: don't leak queued notification



commit 59faad140ec19ea3b47bdaea392a6e24fd79791c
Author: Victor Toso <me victortoso com>
Date:   Thu Sep 29 22:24:13 2016 +0200

    window: don't leak queued notification
    
    358 (40 direct, 318 indirect) bytes in 1 blocks are definitely lost in loss record 15,870 of 16,820
       at 0x9D709EF: g_type_create_instance (gtype.c:1844)
       by 0x9D57ED0: g_object_new_internal (gobject.c:1783)
       by 0x9D58B24: g_object_new_valist (gobject.c:2042)
       by 0x9D57AD0: g_object_new (gobject.c:1626)
       by 0x412EE6: gtd_notification_new (gtd-notification.c:285)
       by 0x428D5F: gtd_window__show_error_message (gtd-window.c:543)
       by 0x9F99C57: ffi_call_unix64 (in /usr/lib64/libffi.so.6.0.2)
       by 0x9F996B9: ffi_call (in /usr/lib64/libffi.so.6.0.2)
       by 0x9D51662: g_cclosure_marshal_generic_va (gclosure.c:1604)
       by 0x9D4FB51: _g_closure_invoke_va (gclosure.c:867)
       by 0x9D6A41A: g_signal_emit_valist (gsignal.c:3300)
       by 0x9D6B59E: g_signal_emit (gsignal.c:3447)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=772212

 src/notification/gtd-notification-widget.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/notification/gtd-notification-widget.c b/src/notification/gtd-notification-widget.c
index dce58d1..701802e 100644
--- a/src/notification/gtd-notification-widget.c
+++ b/src/notification/gtd-notification-widget.c
@@ -192,7 +192,7 @@ gtd_notification_widget_finalize (GObject *object)
   GtdNotificationWidget *self = (GtdNotificationWidget *)object;
   GtdNotificationWidgetPrivate *priv = gtd_notification_widget_get_instance_private (self);
 
-  g_queue_free (priv->queue);
+  g_queue_free_full (priv->queue, g_object_unref);
 
   G_OBJECT_CLASS (gtd_notification_widget_parent_class)->finalize (object);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]