[gnome-todo] plugin-dialog: don't leak GList



commit f51195701c123c96d9638a50d89520632144aae8
Author: Victor Toso <me victortoso com>
Date:   Thu Sep 29 22:07:29 2016 +0200

    plugin-dialog: don't leak GList
    
    48 (24 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 9,427 of 17,018
       at 0x4C2DB9D: malloc (vg_replace_malloc.c:299)
       by 0xA1F890E: g_malloc (gmem.c:94)
       by 0xA212A55: g_slice_alloc (gslice.c:1025)
       by 0xA1EC308: g_list_prepend (glist.c:311)
       by 0x5EE5C42: gtk_container_children_callback (gtkcontainer.c:3304)
       by 0x5FE6773: gtk_list_box_forall (gtklistbox.c:2545)
       by 0x5EE438A: gtk_container_foreach (gtkcontainer.c:2472)
       by 0x5EE4591: gtk_container_get_children (gtkcontainer.c:2536)
       by 0x420505: plugin_loaded (gtd-plugin-dialog.c:115)
       by 0x9F99C57: ffi_call_unix64 (in /usr/lib64/libffi.so.6.0.2)
       by 0x9F996B9: ffi_call (in /usr/lib64/libffi.so.6.0.2)
       by 0x9D51662: g_cclosure_marshal_generic_va (gclosure.c:1604)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=772212

 src/gtd-plugin-dialog.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/src/gtd-plugin-dialog.c b/src/gtd-plugin-dialog.c
index d45da7c..8728190 100644
--- a/src/gtd-plugin-dialog.c
+++ b/src/gtd-plugin-dialog.c
@@ -124,6 +124,8 @@ plugin_loaded (GtdPluginManager *manager,
         }
     }
 
+  g_list_free (children);
+
   /* If we just loaded a plugin that is not yet added
    * to the plugin list, we shall do it now.
    */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]