[epiphany/wip/bookmarks: 37/76] bookmarks: Minor improvements



commit 442d41595391994025dc307e5b23afcf0231c01b
Author: Iulian Radu <iulian radu67 gmail com>
Date:   Tue Aug 16 12:06:55 2016 +0300

    bookmarks: Minor improvements

 src/ephy-bookmark-row.c                       |   11 ++++++-----
 src/ephy-header-bar.c                         |   12 ++++++++----
 src/resources/gtk/bookmark-properties-grid.ui |    1 -
 3 files changed, 14 insertions(+), 10 deletions(-)
---
diff --git a/src/ephy-bookmark-row.c b/src/ephy-bookmark-row.c
index 5c41297..a0e954e 100644
--- a/src/ephy-bookmark-row.c
+++ b/src/ephy-bookmark-row.c
@@ -54,11 +54,12 @@ ephy_bookmark_row_button_clicked_cb (EphyBookmarkRow *row,
   g_assert (EPHY_IS_BOOKMARK_ROW (row));
   g_assert (GTK_IS_BUTTON (button));
 
-  dialog = gtk_dialog_new_with_buttons ("Bookmark Properties",
-                                        GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (row))),
-                                        GTK_DIALOG_USE_HEADER_BAR,
-                                        NULL, NULL);
-  gtk_window_set_modal (GTK_WINDOW (dialog), TRUE);
+  dialog = g_object_new (GTK_TYPE_DIALOG,
+                         "title", "Bookmark Properties",
+                         "transient-for", GTK_WINDOW (gtk_widget_get_toplevel (GTK_WIDGET (row))),
+                         "use-header-bar", TRUE,
+                         "modal", TRUE,
+                         NULL);
 
   content_area = gtk_dialog_get_content_area (GTK_DIALOG (dialog));
 
diff --git a/src/ephy-header-bar.c b/src/ephy-header-bar.c
index d260e0e..f2f6c15 100644
--- a/src/ephy-header-bar.c
+++ b/src/ephy-header-bar.c
@@ -596,6 +596,7 @@ add_bookmark_button_clicked_cb (EphyLocationEntry *entry,
   EphyHeaderBar *header_bar = EPHY_HEADER_BAR (user_data);
   EphyEmbed *embed;
   GtkWidget *popover;
+  GtkWidget *grid;
   GdkRectangle rectangle;
   EphyBookmark *bookmark;
   const char *location;
@@ -621,10 +622,13 @@ add_bookmark_button_clicked_cb (EphyLocationEntry *entry,
                            GTK_ENTRY_ICON_SECONDARY,
                            &rectangle);
   gtk_popover_set_pointing_to (GTK_POPOVER (popover), &rectangle);
-  gtk_container_add (GTK_CONTAINER (popover),
-                     ephy_bookmark_properties_grid_new (bookmark,
-                                                        EPHY_BOOKMARK_PROPERTIES_GRID_TYPE_POPOVER,
-                                                        popover));
+  grid = ephy_bookmark_properties_grid_new (bookmark,
+                                            EPHY_BOOKMARK_PROPERTIES_GRID_TYPE_POPOVER,
+                                            popover);
+  gtk_container_add (GTK_CONTAINER (popover), grid);
+  gtk_popover_set_default_widget (GTK_POPOVER (popover),
+                                  ephy_bookmark_properties_grid_get_add_tag_button 
(EPHY_BOOKMARK_PROPERTIES_GRID (grid)));
+
   g_signal_connect_object (popover, "closed",
                            G_CALLBACK (popover_closed_cb),
                            manager, 0);
diff --git a/src/resources/gtk/bookmark-properties-grid.ui b/src/resources/gtk/bookmark-properties-grid.ui
index af2b8d0..efecc6d 100644
--- a/src/resources/gtk/bookmark-properties-grid.ui
+++ b/src/resources/gtk/bookmark-properties-grid.ui
@@ -117,7 +117,6 @@
             <property name="selection-mode">none</property>
             <property name="homogeneous">true</property>
             <property name="valign">start</property>
-            <property name="min-children-per-line">3</property>
             <property name="max-children-per-line">3</property>
             <property name="visible">true</property>
           </object>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]