[tracker/wip/sam/meson] tests: Avoid horrible hang in test-tracker-resource
- From: Sam Thursfield <sthursfield src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [tracker/wip/sam/meson] tests: Avoid horrible hang in test-tracker-resource
- Date: Sun, 25 Sep 2016 13:21:00 +0000 (UTC)
commit 91914d420549fa8a708cd3315e2c02d0f66dd5f4
Author: Sam Thursfield <sam afuera me uk>
Date: Sat Sep 3 11:05:25 2016 +0100
tests: Avoid horrible hang in test-tracker-resource
Seems that missing the 'return' statement from a
g_test_trap_subprocess() block can result in hanging Linux completely;
some kind of fork bomb I guess. The problem only hits when the test is
failing, so I didn't spot the mistake before.
tests/libtracker-sparql/tracker-resource-test.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/tests/libtracker-sparql/tracker-resource-test.c b/tests/libtracker-sparql/tracker-resource-test.c
index cab3524..4c86fe8 100644
--- a/tests/libtracker-sparql/tracker-resource-test.c
+++ b/tests/libtracker-sparql/tracker-resource-test.c
@@ -134,8 +134,10 @@ test_resource_get_set_pointer_validation (void)
resource = tracker_resource_new ("http://example.com/resource");
- /* This will trigger a g_warning(), and abort. */
+ /* This should trigger a g_warning(), and abort. */
tracker_resource_set_string (resource, "http://example.com/1", NULL);
+
+ return;
}
g_test_trap_subprocess (NULL, 0, 0);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]