[gnome-builder] subprocess: rely on system to provide stream closure
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] subprocess: rely on system to provide stream closure
- Date: Fri, 16 Sep 2016 20:08:22 +0000 (UTC)
commit 87e30b068d45a6d7b48b6f9363b961b70eb8f969
Author: Christian Hergert <chergert redhat com>
Date: Fri Sep 16 13:04:19 2016 -0700
subprocess: rely on system to provide stream closure
We do not need to manually close these, as that should automatically happen
for us. Now that a lot of the other racing bugs are fixed, this crutch
should not be needed anymore.
libide/subprocess/ide-breakout-subprocess.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
---
diff --git a/libide/subprocess/ide-breakout-subprocess.c b/libide/subprocess/ide-breakout-subprocess.c
index 3b1fb67..5a1a0ea 100644
--- a/libide/subprocess/ide-breakout-subprocess.c
+++ b/libide/subprocess/ide-breakout-subprocess.c
@@ -1022,15 +1022,6 @@ ide_breakout_subprocess_complete_command_locked (IdeBreakoutSubprocess *self,
g_signal_handler_disconnect (self->connection, self->connection_closed_handler);
self->connection_closed_handler = 0;
- if (self->stdin_pipe && !g_output_stream_is_closed (self->stdin_pipe))
- g_output_stream_close (self->stdin_pipe, NULL, NULL);
-
- if (self->stdout_pipe && !g_input_stream_is_closed (self->stdout_pipe))
- g_input_stream_close (self->stdout_pipe, NULL, NULL);
-
- if (self->stderr_pipe && !g_input_stream_is_closed (self->stderr_pipe))
- g_input_stream_close (self->stderr_pipe, NULL, NULL);
-
g_clear_object (&self->connection);
if (self->main_context != NULL)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]