[nautilus/wip/csoriano/batch-refactoring] Continue refactoring

[Carlos Soriano Sánchez <csoriano src gnome org>]

commit fdd22995c73090de65f8ce4832d505bf6458276d
Author: Carlos Soriano <csoriano gnome org>
Date:   Mon Sep 12 00:14:43 2016 +0200

    Continue refactoring

 src/nautilus-batch-rename-dialog.c    |    6 +++++-
 src/nautilus-batch-rename-utilities.c |   18 ++++++++++++------
 2 files changed, 17 insertions(+), 7 deletions(-)
---
diff --git a/src/nautilus-batch-rename-dialog.c b/src/nautilus-batch-rename-dialog.c
index 1ccf985..37441ae 100644
--- a/src/nautilus-batch-rename-dialog.c
+++ b/src/nautilus-batch-rename-dialog.c
@@ -365,6 +365,7 @@ split_entry_text (NautilusBatchRenameDialog *self,
         }
     }
 
+    g_print ("split text %d\n", tags);
     g_array_sort (tag_positions, compare_tag_position);
 
     for (i = 0; i < tags; i++)
@@ -1693,6 +1694,7 @@ nautilus_batch_rename_dialog_query_finished (NautilusBatchRenameDialog *dialog,
         }
 
         metadata_type = tag_data->tag_constants.metadata_type;
+        g_print ("metadat type %s\n", tag_data->tag_constants.text_representation);
         if (file_metadata->metadata[metadata_type] == NULL ||
             file_metadata->metadata[metadata_type]->len <= 0)
         {
@@ -1701,7 +1703,7 @@ nautilus_batch_rename_dialog_query_finished (NautilusBatchRenameDialog *dialog,
         }
         else
         {
-            tag_data->set = FALSE;
+        g_print ("disabling metadat type %s\n", tag_data->tag_constants.text_representation);
         }
     }
 }
@@ -1905,6 +1907,7 @@ remove_tag (NautilusBatchRenameDialog *dialog,
                                           g_utf8_offset_to_pointer (entry_text->str,
                                                                     tag_data->position + g_utf8_strlen 
(tag_name, -1)));
 
+        g_print ("deleting tag!!! %s\n", tag_data->tag_constants.text_representation);
         tag_data->set = FALSE;
         dialog->cursor_position = tag_data->position;
         dialog->use_manual_cursor_position = TRUE;
@@ -1948,6 +1951,7 @@ remove_tag_selection (NautilusBatchRenameDialog *dialog,
                                           g_utf8_offset_to_pointer (old_entry_text->str,
                                                                     tag_data->new_position + g_utf8_strlen 
(tag_name, -1)));
 
+        g_print ("removing tag selection\n");
         tag_data->set = FALSE;
 
         action = g_action_map_lookup_action (G_ACTION_MAP (dialog->action_group),
diff --git a/src/nautilus-batch-rename-utilities.c b/src/nautilus-batch-rename-utilities.c
index faac4da..b94f516 100644
--- a/src/nautilus-batch-rename-utilities.c
+++ b/src/nautilus-batch-rename-utilities.c
@@ -226,6 +226,7 @@ batch_rename_format (NautilusFile *file,
     GString *tag_string;
     GString *new_name;
     gboolean added_tag;
+    MetadataType metadata_type;
     g_autofree gchar *file_name = NULL;
     g_autofree gchar *extension = NULL;
     gint i;
@@ -287,17 +288,20 @@ batch_rename_format (NautilusFile *file,
             translated_tag = gettext (metadata_tags_constants[i].text_representation);
             if (g_strcmp0 (tag_string->str, translated_tag) == 0)
             {
-                metadata = get_metadata (selection_metadata, file_name,
-                                         metadata_tags_constants[i].metadata_type);
+                metadata_type = metadata_tags_constants[i].metadata_type;
+                metadata = get_metadata (selection_metadata, file_name, metadata_type);
 
-                if (!metadata)
+                /* TODO: This is a hack, we should provide a cancellable for checking
+                 * the metadata, and if that is happening don't enter here. We can
+                 * special case original file name upper in the call stack */
+                if (!metadata && metadata_type != ORIGINAL_FILE_NAME)
                 {
                     g_warning ("Metadata not present in one file, it shouldn't have been added. File name: 
%s, Metadata: %s",
                                file_name, metadata_tags_constants[i].text_representation);
                     continue;
                 }
 
-                switch (metadata_tags_constants[i].metadata_type)
+                switch (metadata_type)
                 {
                     case ORIGINAL_FILE_NAME:
                     {
@@ -368,9 +372,8 @@ batch_rename_dialog_get_new_names_list (NautilusBatchRenameDialogMode  mode,
     {
         file = NAUTILUS_FILE (l->data);
 
-        file_name = g_string_new ("");
         name = nautilus_file_get_name (file);
-        g_string_append (file_name, name);
+        file_name = g_string_new (name);
 
         /* get the new name here and add it to the list*/
         if (mode == NAUTILUS_BATCH_RENAME_DIALOG_FORMAT)
@@ -741,6 +744,7 @@ on_cursor_callback (GObject      *object,
     {
         if (query_data->has_metadata[i])
         {
+            g_print ("metadata type %s\n", metadata_tags_constants[i].text_representation);
             metadata_type = metadata_tags_constants[i].metadata_type;
             current_metadata = NULL;
             switch (metadata_type)
@@ -748,6 +752,7 @@ on_cursor_callback (GObject      *object,
                 case ORIGINAL_FILE_NAME:
                 {
                     current_metadata = file_name;
+                    g_print ("original file name %s\n", file_name);
                 }
                 break;
                 case CREATION_DATE:
@@ -938,6 +943,7 @@ check_metadata_for_selection (NautilusBatchRenameDialog *dialog,
         }
 
         file_metadata = g_new0 (FileMetadata, 1);
+        file_metadata->file_name = g_string_new (file_name);
         file_metadata->metadata[ORIGINAL_FILE_NAME] = g_string_new (file_name);
 
         selection_metadata = g_list_append (selection_metadata, file_metadata);