[network-manager-openvpn: 5/7] import: don't return content from config in failure message



commit 62daac8b2b467853e907a7621873f71a13cec6bc
Author: Thomas Haller <thaller redhat com>
Date:   Thu Sep 8 11:52:09 2016 +0200

    import: don't return content from config in failure message
    
    The error message should not quote parts of the ovpn file that might
    contain sensitive data. Instead, it is enough that the error message
    contains the line-number and the property which fails.

 properties/import-export.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/properties/import-export.c b/properties/import-export.c
index ea9406a..957453f 100644
--- a/properties/import-export.c
+++ b/properties/import-export.c
@@ -1265,7 +1265,7 @@ do_import (const char *path, const char *contents, gsize contents_len, GError **
                                                   NM_OPENVPN_VERIFY_X509_NAME_TYPE_SUBJECT,
                                                   NM_OPENVPN_VERIFY_X509_NAME_TYPE_NAME,
                                                   NM_OPENVPN_VERIFY_X509_NAME_TYPE_NAME_PREFIX)) {
-                                       line_error = g_strdup_printf (_("Invalid verify-x509-name type: %s"), 
params[2]);
+                                       line_error = g_strdup_printf (_("invalid verify-x509-name type"));
                                        goto handle_line_error;
                                }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]