[gnome-software] trivial: Add ERROR_DOWNLOAD_FAILED

[Richard Hughes <rhughes src gnome org>]

commit 3365411e3e4fabde5d8dafe4f92097dc6dc47b96
Author: Richard Hughes <richard hughsie com>
Date:   Wed Sep 7 14:56:44 2016 +0100

    trivial: Add ERROR_DOWNLOAD_FAILED

 src/gs-plugin.c                        |    6 ++++--
 src/gs-plugin.h                        |    2 ++
 src/plugins/gs-plugin-icons.c          |    2 +-
 src/plugins/gs-plugin-odrs.c           |    4 ++--
 src/plugins/gs-plugin-ubuntu-reviews.c |    2 +-
 5 files changed, 10 insertions(+), 6 deletions(-)
---
diff --git a/src/gs-plugin.c b/src/gs-plugin.c
index 7fb0f60..0bb5ca8 100644
--- a/src/gs-plugin.c
+++ b/src/gs-plugin.c
@@ -1094,7 +1094,7 @@ gs_plugin_download_data (GsPlugin *plugin,
                }
                g_set_error (error,
                             GS_PLUGIN_ERROR,
-                            GS_PLUGIN_ERROR_FAILED,
+                            GS_PLUGIN_ERROR_DOWNLOAD_FAILED,
                             "failed to download %s: %s",
                             uri, str->str);
                return NULL;
@@ -1152,7 +1152,7 @@ gs_plugin_download_file (GsPlugin *plugin,
                }
                g_set_error (error,
                             GS_PLUGIN_ERROR,
-                            GS_PLUGIN_ERROR_FAILED,
+                            GS_PLUGIN_ERROR_DOWNLOAD_FAILED,
                             "failed to download %s: %s",
                             uri, str->str);
                return FALSE;
@@ -1303,6 +1303,8 @@ gs_plugin_error_to_string (GsPluginError error)
                return "account-deactivated";
        if (error == GS_PLUGIN_ERROR_PLUGIN_DEPSOLVE_FAILED)
                return "plugin-depsolve-failed";
+       if (error == GS_PLUGIN_ERROR_DOWNLOAD_FAILED)
+               return "download-failed";
        return NULL;
 }
 
diff --git a/src/gs-plugin.h b/src/gs-plugin.h
index 99f9160..44e54ae 100644
--- a/src/gs-plugin.h
+++ b/src/gs-plugin.h
@@ -111,6 +111,7 @@ typedef guint64 GsPluginFlags;
  * @GS_PLUGIN_ERROR_ACCOUNT_SUSPENDED:         User account has been suspended
  * @GS_PLUGIN_ERROR_ACCOUNT_DEACTIVATED:       User account has been deactivated
  * @GS_PLUGIN_ERROR_PLUGIN_DEPSOLVE_FAILED:    The plugins installed are incompatible
+ * @GS_PLUGIN_ERROR_DOWNLOAD_FAILED:           The download action failed
  *
  * The failure error types.
  **/
@@ -127,6 +128,7 @@ typedef enum {
        GS_PLUGIN_ERROR_ACCOUNT_SUSPENDED,
        GS_PLUGIN_ERROR_ACCOUNT_DEACTIVATED,
        GS_PLUGIN_ERROR_PLUGIN_DEPSOLVE_FAILED,
+       GS_PLUGIN_ERROR_DOWNLOAD_FAILED,
        /*< private >*/
        GS_PLUGIN_ERROR_LAST
 } GsPluginError;
diff --git a/src/plugins/gs-plugin-icons.c b/src/plugins/gs-plugin-icons.c
index ef0df68..2054288 100644
--- a/src/plugins/gs-plugin-icons.c
+++ b/src/plugins/gs-plugin-icons.c
@@ -89,7 +89,7 @@ gs_plugin_icons_download (GsPlugin *plugin,
        if (status_code != SOUP_STATUS_OK) {
                g_set_error (error,
                             GS_PLUGIN_ERROR,
-                            GS_PLUGIN_ERROR_FAILED,
+                            GS_PLUGIN_ERROR_DOWNLOAD_FAILED,
                             "Failed to download icon %s: %s",
                             uri, soup_status_get_phrase (status_code));
                return FALSE;
diff --git a/src/plugins/gs-plugin-odrs.c b/src/plugins/gs-plugin-odrs.c
index db1c10a..9fc9e4a 100644
--- a/src/plugins/gs-plugin-odrs.c
+++ b/src/plugins/gs-plugin-odrs.c
@@ -565,7 +565,7 @@ gs_plugin_odrs_fetch_for_app (GsPlugin *plugin, GsApp *app, GError **error)
                /* not sure what to do here */
                g_set_error_literal (error,
                                     GS_PLUGIN_ERROR,
-                                    GS_PLUGIN_ERROR_FAILED,
+                                    GS_PLUGIN_ERROR_DOWNLOAD_FAILED,
                                     "status code invalid");
                return NULL;
        }
@@ -945,7 +945,7 @@ gs_plugin_add_unvoted_reviews (GsPlugin *plugin,
                /* not sure what to do here */
                g_set_error_literal (error,
                                     GS_PLUGIN_ERROR,
-                                    GS_PLUGIN_ERROR_FAILED,
+                                    GS_PLUGIN_ERROR_DOWNLOAD_FAILED,
                                     "status code invalid");
                return FALSE;
        }
diff --git a/src/plugins/gs-plugin-ubuntu-reviews.c b/src/plugins/gs-plugin-ubuntu-reviews.c
index f9784ee..4cbb530 100644
--- a/src/plugins/gs-plugin-ubuntu-reviews.c
+++ b/src/plugins/gs-plugin-ubuntu-reviews.c
@@ -439,7 +439,7 @@ download_review_stats (GsPlugin *plugin, GCancellable *cancellable, GError **err
        if (status_code != SOUP_STATUS_OK) {
                g_set_error (error,
                             GS_PLUGIN_ERROR,
-                            GS_PLUGIN_ERROR_FAILED,
+                            GS_PLUGIN_ERROR_DOWNLOAD_FAILED,
                             "Failed to download review stats, server returned status code %u",
                             status_code);
                return FALSE;