[gnome-online-miners/wip/rishi/insert-share: 7/19] miner: Remove a one-line convenience function



commit adad87e80a4dd24b90e2ef7437c3111ca2ceec36
Author: Debarshi Ray <debarshir gnome org>
Date:   Fri Sep 2 16:02:29 2016 +0200

    miner: Remove a one-line convenience function
    
    The port to GTask has simplified gom_miner_complete_error to the point
    where we can directly use g_task_return_error.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=770889

 src/gom-miner.c |   12 ++----------
 1 files changed, 2 insertions(+), 10 deletions(-)
---
diff --git a/src/gom-miner.c b/src/gom-miner.c
index 5bdd7b2..7d33526 100644
--- a/src/gom-miner.c
+++ b/src/gom-miner.c
@@ -176,14 +176,6 @@ gom_miner_class_init (GomMinerClass *klass)
 }
 
 static void
-gom_miner_complete_error (GomMiner *self,
-                          GError *error)
-{
-  g_assert (self->priv->task != NULL);
-  g_task_return_error (self->priv->task, g_error_copy (error));
-}
-
-static void
 gom_miner_check_pending_jobs (GomMiner *self)
 {
   if (g_list_length (self->priv->pending_jobs) == 0)
@@ -730,13 +722,13 @@ gom_miner_refresh_db_async (GomMiner *self,
 
   if (self->priv->client_error != NULL)
     {
-      gom_miner_complete_error (self, self->priv->client_error);
+      g_task_return_error (self->priv->task, g_error_copy (self->priv->client_error));
       return;
     }
 
   if (self->priv->connection_error != NULL)
     {
-      gom_miner_complete_error (self, self->priv->connection_error);
+      g_task_return_error (self->priv->task, g_error_copy (self->priv->connection_error));
       return;
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]