[chronojump/chronojump-importer] insert_data() now returns a new data set instead of modifying the passed one.
- From: Carles Pina i Estany <carlespina src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [chronojump/chronojump-importer] insert_data() now returns a new data set instead of modifying the passed one.
- Date: Mon, 5 Sep 2016 11:29:34 +0000 (UTC)
commit c78f82729a773dcc9737560b55e14d73506221a7
Author: Carles Pina i Estany <carles pina cat>
Date: Mon Sep 5 12:29:02 2016 +0100
insert_data() now returns a new data set instead of modifying the passed one.
src/chronojump-importer/chronojump_importer.py | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
---
diff --git a/src/chronojump-importer/chronojump_importer.py b/src/chronojump-importer/chronojump_importer.py
index 03f7c39..44e131c 100755
--- a/src/chronojump-importer/chronojump_importer.py
+++ b/src/chronojump-importer/chronojump_importer.py
@@ -1,5 +1,6 @@
#!/usr/bin/env python3
+import copy
import argparse
import sqlite3
import sys
@@ -50,11 +51,13 @@ def add_prefix(list_of_elements, prefix):
def insert_data(database, table_name, data, matches_columns):
""" Inserts data (list of dictionaries) into table_name for database.
- Modifies data and adds new_unique_id. This is the new uniqueid or an
+ Returns a copy of data and adds new_unique_id. This is the new uniqueid or an
existing one if a register with matches_columns already existed. """
+
+ data_result = copy.deepcopy(data)
cursor = database.cursor()
- for row in data:
+ for row in data_result:
# First check if this already existed
where = ""
@@ -86,6 +89,8 @@ def insert_data(database, table_name, data, matches_columns):
database.commit()
+ return data_result
+
def return_data_from_table(database, table_name, where_condition, skip_columns, join_clause =""):
""" Returns a list of lists of the database, table executing where and skips the columns. """
@@ -427,7 +432,7 @@ def import_database(source_path, destination_path, source_session):
where_condition="Session.uniqueID={}".format(source_session),
skip_columns=["uniqueID"])
- insert_data(database=destination_db, table_name="Session", data=session,
+ session = insert_data(database=destination_db, table_name="Session", data=session,
matches_columns=["name", "place", "date", "personsSportID",
"personsSpeciallityID", "personsPractice", "comments"])
new_session_id = session[0]['new_unique_id']
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]