[gnome-builder] Revert "autotools: make a copy of configuration"



commit f939a8df502ed4c036d75849ff3175dda13427cb
Author: Christian Hergert <chergert redhat com>
Date:   Fri Oct 28 23:45:40 2016 -0700

    Revert "autotools: make a copy of configuration"
    
    This reverts commit 1d0a3273d5b06a488778d23ae225225e4f28dc3e.
    
    We need the real configuration instance so that we can clear the dirty bit.
    However, we should make sure we get all our data upfront before we spawn our
    worker thread.

 plugins/autotools/ide-autotools-build-task.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)
---
diff --git a/plugins/autotools/ide-autotools-build-task.c b/plugins/autotools/ide-autotools-build-task.c
index 9939c8b..7f83d00 100644
--- a/plugins/autotools/ide-autotools-build-task.c
+++ b/plugins/autotools/ide-autotools-build-task.c
@@ -226,17 +226,10 @@ static void
 ide_autotools_build_task_set_configuration (IdeAutotoolsBuildTask *self,
                                             IdeConfiguration      *configuration)
 {
-  g_autoptr(IdeConfiguration) copy = NULL;
-
   g_assert (IDE_IS_AUTOTOOLS_BUILD_TASK (self));
   g_assert (IDE_IS_CONFIGURATION (configuration));
 
-  /* Work on a duplication of the configuration so that we don't need to
-   * synchronize with other threads. */
-  if (configuration != NULL)
-    copy = ide_configuration_duplicate (configuration);
-
-  if (g_set_object (&self->configuration, copy))
+  if (g_set_object (&self->configuration, configuration))
     g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_CONFIGURATION]);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]