[tracker/wip/split/core: 1/5] libtracker-miner: Remove all traces of libmediaart
- From: Carlos Garnacho <carlosg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [tracker/wip/split/core: 1/5] libtracker-miner: Remove all traces of libmediaart
- Date: Fri, 28 Oct 2016 11:10:32 +0000 (UTC)
commit 43813f3fab2413481d8b84b4b8f7261daaad8020
Author: Carlos Garnacho <carlosg gnome org>
Date: Wed Oct 26 17:58:32 2016 +0200
libtracker-miner: Remove all traces of libmediaart
We just happen to use it to remove related media art when files
are deleted. This should instead be deferred to a low urgency
maintenance task (and probably outside tracker, the albumart
dir is not just ours).
Anyway, tracker never got this entirely right, there can be
other copies of the files which would get their albumart
taken away of a sudden. Or we are simply not guaranteed to
receive file monitor events (eg. disabling the setting, or
due to monitor exhaustion).
src/libtracker-miner/Makefile.am | 6 -
src/libtracker-miner/tracker-media-art.c | 242 ------------------------------
src/libtracker-miner/tracker-media-art.h | 37 -----
src/libtracker-miner/tracker-miner-fs.c | 8 -
tests/tracker-writeback/01-writeback.py | 102 -------------
tests/tracker-writeback/Makefile.am | 8 -
tests/tracker-writeback/data/test01.jpg | Bin 306 -> 0 bytes
tests/tracker-writeback/tests.xml | 28 ----
8 files changed, 0 insertions(+), 431 deletions(-)
---
diff --git a/src/libtracker-miner/Makefile.am b/src/libtracker-miner/Makefile.am
index 25cda0e..8aa18f4 100644
--- a/src/libtracker-miner/Makefile.am
+++ b/src/libtracker-miner/Makefile.am
@@ -53,12 +53,6 @@ private_sources = \
tracker-utils.c \
tracker-utils.h
-if HAVE_LIBMEDIAART
-private_sources += \
- tracker-media-art.c \
- tracker-media-art.h
-endif
-
miner_sources = \
$(libtracker_miner_monitor_sources) \
$(libtracker_miner_monitor_headers) \
diff --git a/src/libtracker-miner/tracker-miner-fs.c b/src/libtracker-miner/tracker-miner-fs.c
index 02b4a47..4f22473 100644
--- a/src/libtracker-miner/tracker-miner-fs.c
+++ b/src/libtracker-miner/tracker-miner-fs.c
@@ -23,7 +23,6 @@
#include "tracker-crawler.h"
#include "tracker-miner-fs.h"
-#include "tracker-media-art.h"
#include "tracker-monitor.h"
#include "tracker-utils.h"
#include "tracker-thumbnailer.h"
@@ -1637,10 +1636,6 @@ item_remove (TrackerMinerFS *fs,
if (!only_children) {
if (fs->priv->thumbnailer)
tracker_thumbnailer_remove_add (fs->priv->thumbnailer, uri, NULL);
-
-#ifdef HAVE_LIBMEDIAART
- tracker_media_art_queue_remove (uri, NULL);
-#endif
}
g_object_set_qdata (G_OBJECT (file),
@@ -2551,9 +2546,6 @@ item_queue_handlers_cb (gpointer user_data)
if (fs->priv->thumbnailer)
tracker_thumbnailer_send (fs->priv->thumbnailer);
-#ifdef HAVE_LIBMEDIAART
- tracker_media_art_queue_empty (tracker_miner_get_connection (TRACKER_MINER
(fs)));
-#endif
} else {
/* Flush any possible pending update here */
tracker_sparql_buffer_flush (fs->priv->sparql_buffer,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]