[evolution] EEditorPage is never freed
- From: Tomas Popela <tpopela src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution] EEditorPage is never freed
- Date: Thu, 20 Oct 2016 14:54:05 +0000 (UTC)
commit 66bdaaecfc0bb10ce0709ea77a6551456d4145a2
Author: Tomas Popela <tpopela redhat com>
Date: Thu Oct 20 16:50:32 2016 +0200
EEditorPage is never freed
We were comparing the address of a WebKitWebPage object with an
EEditorPage one.
.../web-extension/e-editor-web-extension.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/src/modules/webkit-editor/web-extension/e-editor-web-extension.c
b/src/modules/webkit-editor/web-extension/e-editor-web-extension.c
index 48aedd3..eb56e43 100644
--- a/src/modules/webkit-editor/web-extension/e-editor-web-extension.c
+++ b/src/modules/webkit-editor/web-extension/e-editor-web-extension.c
@@ -2253,7 +2253,10 @@ web_page_gone_cb (gpointer user_data,
g_hash_table_iter_init (&iter, extension->priv->editor_pages);
while (g_hash_table_iter_next (&iter, &key, &value)) {
- if (value == gone_web_page) {
+ EEditorPage *editor_page = E_EDITOR_PAGE (value);
+ WebKitWebPage *web_page = e_editor_page_get_web_page (editor_page);
+
+ if ((gpointer) web_page == gone_web_page) {
g_hash_table_remove (extension->priv->editor_pages, key);
break;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]