[epiphany] sync-service: Fix double free crash



commit 0d3da9a3c7852b65970ae4fd9567b1218c2f9f2c
Author: Gabriel Ivascu <ivascu gabriel59 gmail com>
Date:   Tue Nov 29 12:21:52 2016 +0200

    sync-service: Fix double free crash
    
    The bundle returned by _start_sign_in() is a parameter to _finish_sign_in().
    Don't free it inside _finish_sign_in().

 src/prefs-dialog.c           |    1 +
 src/sync/ephy-sync-service.c |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/prefs-dialog.c b/src/prefs-dialog.c
index d79e724..a2bbde7 100644
--- a/src/prefs-dialog.c
+++ b/src/prefs-dialog.c
@@ -261,6 +261,7 @@ poll_fxa_server (gpointer user_data)
                                       data->respHMACkey, data->respXORkey);
     hide_fxa_iframe (data->dialog, data->email);
 
+    g_free (bundle);
     fxa_callback_data_free (data);
     data->dialog->source_id = 0;
 
diff --git a/src/sync/ephy-sync-service.c b/src/sync/ephy-sync-service.c
index 4ded2ef..b43cf3f 100644
--- a/src/sync/ephy-sync-service.c
+++ b/src/sync/ephy-sync-service.c
@@ -926,7 +926,6 @@ ephy_sync_service_finish_sign_in (EphySyncService *self,
 
   g_free (kA);
   g_free (kB);
-  g_free (bundle);
   g_free (unwrapKB);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]