[network-manager-applet] c-e: avoid setting "full" as default duplex value.



commit 037b61b71ccc8126e2a65504deaf0207fb7e3de4
Author: poma <pomidorabelisima gmail com>
Date:   Fri Nov 25 16:47:34 2016 +0100

    c-e: avoid setting "full" as default duplex value.
    
    NetworkManager 802-3 link properties have been implemented in:
    https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e0c50a97037
    'auto-negotiate' default value has been also changed to "false", as
    together with 'speed' = 0 and duplex unset (NULL) instructs
    NetworkManager to skip link configuration.
    Before the implementation, the 'auto-negotiate', 'speed' and 'duplex'
    802-3 properties were ignored, without regards of the value they were
    set. The duplex property in particular was silently set to "full" by c-e
    for each connection modified. This triggers NetworkManager to force a
    static link configuration with duplex mode and unspecified speed.
    
    [fgiudici redhat com: rewritten the commit message]

 src/connection-editor/page-ethernet.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/src/connection-editor/page-ethernet.c b/src/connection-editor/page-ethernet.c
index 8593f82..b0e100c 100644
--- a/src/connection-editor/page-ethernet.c
+++ b/src/connection-editor/page-ethernet.c
@@ -446,7 +446,6 @@ ui_to_setting (CEPageEthernet *self)
                      NM_SETTING_WIRED_CLONED_MAC_ADDRESS, cloned_mac && *cloned_mac ? cloned_mac : NULL,
                      NM_SETTING_WIRED_PORT, port,
                      NM_SETTING_WIRED_SPEED, speed,
-                     NM_SETTING_WIRED_DUPLEX, gtk_toggle_button_get_active (priv->duplex) ? "full" : "half",
                      NM_SETTING_WIRED_AUTO_NEGOTIATE, gtk_toggle_button_get_active (priv->autonegotiate),
                      NM_SETTING_WIRED_WAKE_ON_LAN, wol,
                      NM_SETTING_WIRED_WAKE_ON_LAN_PASSWORD, wol_passwd && *wol_passwd ? wol_passwd : NULL,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]