[epiphany] bookmark: Fix leak of id



commit 2aa60af0b078af9e2776cbca4812d3345721db05
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Mon Nov 21 14:46:55 2016 -0600

    bookmark: Fix leak of id
    
    Direct leak of 891 byte(s) in 27 object(s) allocated from:
        #0 0x7f037a037e60 in malloc (/lib64/libasan.so.3+0xc6e60)
        #1 0x7f0365b418f6 in g_malloc
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:94
        #2 0x7f0365b41bb3 in g_malloc_n
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:331
        #3 0x7f0365b5e4d8 in g_strdup
    /home/mcatanzaro/src/jhbuild/checkout/glib/glib/gstrfuncs.c:363
        #4 0x7f03799e74fc in ephy_bookmark_set_id
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmark.c:353
        #5 0x7f03799ee6b5 in ephy_bookmarks_manager_load_from_file
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:620
        #6 0x7f03799ed26a in ephy_bookmarks_manager_init
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:223
        #7 0x7f03691b5c55 in g_type_create_instance
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
        #8 0x7f036919c2aa in g_object_new_internal
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
        #9 0x7f036919c7b9 in g_object_newv
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1930
        #10 0x7f036919be5b in g_object_new
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1623
        #11 0x7f03799ed2fc in ephy_bookmarks_manager_new
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:245
        #12 0x7f0379a0b45d in ephy_shell_get_bookmarks_manager
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-shell.c:774
        #13 0x7f03799f0d05 in ephy_bookmarks_popover_init
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-popover.c:485
        #14 0x7f03691b5c55 in g_type_create_instance
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
        #15 0x7f036919c2aa in g_object_new_internal
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
        #16 0x7f036919cefe in g_object_new_valist
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
        #17 0x7f036919beaa in g_object_new
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
        #18 0x7f03799f13a4 in ephy_bookmarks_popover_new
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-popover.c:559
        #19 0x7f03799f8dbe in ephy_header_bar_constructed
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-header-bar.c:701
        #20 0x7f036919c3f5 in g_object_new_internal
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1823
        #21 0x7f036919cefe in g_object_new_valist
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
        #22 0x7f036919beaa in g_object_new
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
        #23 0x7f03799f9583 in ephy_header_bar_new
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-header-bar.c:793
        #24 0x7f0379a15fcf in setup_header_bar
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:2835
        #25 0x7f0379a16850 in ephy_window_constructed
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:3005
        #26 0x7f036919c3f5 in g_object_new_internal
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1823
        #27 0x7f036919cefe in g_object_new_valist
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
        #28 0x7f036919beaa in g_object_new
    /home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
        #29 0x7f0379a17200 in ephy_window_new
    /home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:3134

 src/bookmarks/ephy-bookmark.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/bookmarks/ephy-bookmark.c b/src/bookmarks/ephy-bookmark.c
index 5d2a9fa..ff6b5b4 100644
--- a/src/bookmarks/ephy-bookmark.c
+++ b/src/bookmarks/ephy-bookmark.c
@@ -132,6 +132,7 @@ ephy_bookmark_finalize (GObject *object)
 
   g_clear_pointer (&self->url, g_free);
   g_clear_pointer (&self->title, g_free);
+  g_clear_pointer (&self->id, g_free);
 
   g_sequence_free (self->tags);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]