[gtkmm/gtkmm-3-22] Label(): don't use misleading align argument names



commit 44ec9c2dd07f1c1aa25aec62c85dda6844f1b3a3
Author: djb <db0451 gmail com>
Date:   Thu Nov 17 22:03:39 2016 +0000

    Label(): don't use misleading align argument names
    
    These arguments are forwarded to set_halign() and set_valign(), yet they
    were named xalign and yalign, which is especially confusing because
    Label already has completely separate xalign and yalign properties.
    This could lead to users getting confused when they think they're
    setting one of these pairs of properties but actually setting the other.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774652

 gtk/src/label.hg |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/gtk/src/label.hg b/gtk/src/label.hg
index 4e8dbb3..a962778 100644
--- a/gtk/src/label.hg
+++ b/gtk/src/label.hg
@@ -66,16 +66,16 @@ _DEPRECATE_IFDEF_END
    * when you want to create a label with alignment different
    * than default one.
    * @code
-   * Gtk::Label label(text, x, y, mnemonic);
+   * Gtk::Label label(text, h, v, mnemonic);
    * @endcode
    * is equivalent to:
    * @code
    * Gtk::Label label(text, mnemonic);
-   * label.set_halign(x);
-   * label.set_valign(y);
+   * label.set_halign(h);
+   * label.set_valign(v);
    * @endcode
    */
-  Label(const Glib::ustring& label, Align xalign, Align yalign = ALIGN_CENTER, bool mnemonic = false);
+  Label(const Glib::ustring& label, Align halign, Align valign = ALIGN_CENTER, bool mnemonic = false);
 
 
   /// Doesn't use markup.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]