[gvfs] udisks2: Always use generic notification when unmounting
- From: Ondrej Holy <oholy src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gvfs] udisks2: Always use generic notification when unmounting
- Date: Fri, 18 Nov 2016 08:13:12 +0000 (UTC)
commit f760443a989a5d2f3e5b768c2fa429cdfe653917
Author: Ondrej Holy <oholy redhat com>
Date: Thu Nov 10 14:21:22 2016 +0100
udisks2: Always use generic notification when unmounting
"You can now unplug %s\n" is used for mounts with filesystem,
"%s has been unmounted\n" is used otherwise when unmounting.
It is confusing to say "unplug" for drives with multiple mounts,
or for drives, which need to be ejected, or stopped. I think
"unplug" should be used only when ejecting, or stopping. It might
lead to data loss if user unplug the device after unmounting one
of several mounts.
https://bugzilla.gnome.org/show_bug.cgi?id=774192
monitor/udisks2/gvfsudisks2mount.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/monitor/udisks2/gvfsudisks2mount.c b/monitor/udisks2/gvfsudisks2mount.c
index 29f2a3d..860903c 100644
--- a/monitor/udisks2/gvfsudisks2mount.c
+++ b/monitor/udisks2/gvfsudisks2mount.c
@@ -962,7 +962,7 @@ unmount_do (UnmountData *data,
if (data->mount_operation != NULL)
gvfs_udisks2_unmount_notify_start (data->mount_operation,
G_MOUNT (data->mount), NULL,
- (data->filesystem == NULL));
+ TRUE);
/* Use the umount(8) command if there is no block device / filesystem */
if (data->filesystem == NULL)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]