[gnome-builder] sourceview: no need to check forward char



commit a76bbc0b48f10dcb9903e2664cba75b93fd5a692
Author: Christian Hergert <chergert redhat com>
Date:   Thu Nov 17 03:32:03 2016 -0800

    sourceview: no need to check forward char
    
    We already know we want to overwrite and what our bounds are. No need to
    check again, as this can only break when we are at the end of the buffer.

 libide/sourceview/ide-source-view.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/libide/sourceview/ide-source-view.c b/libide/sourceview/ide-source-view.c
index 2d905aa..33b1198 100644
--- a/libide/sourceview/ide-source-view.c
+++ b/libide/sourceview/ide-source-view.c
@@ -1785,11 +1785,9 @@ ide_source_view_maybe_overwrite (IdeSourceView *self,
 
   next = insert;
 
-  if (gtk_text_iter_forward_char (&next))
-    {
-      gtk_text_buffer_delete (buffer, &insert, &next);
-      *iter = insert;
-    }
+  gtk_text_iter_forward_char (&next);
+  gtk_text_buffer_delete (buffer, &insert, &next);
+  *iter = insert;
 }
 
 static gboolean


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]