[gtk+] entry: Avoid recursion in gtk_entry_ensure_layout
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] entry: Avoid recursion in gtk_entry_ensure_layout
- Date: Mon, 14 Nov 2016 20:18:23 +0000 (UTC)
commit d462c312332df0b551a33506568b97fac579e5cb
Author: Matthias Clasen <mclasen redhat com>
Date: Mon Nov 14 15:17:41 2016 -0500
entry: Avoid recursion in gtk_entry_ensure_layout
This was unintentional, and lead to a memory leak.
gtk/gtkentry.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
---
diff --git a/gtk/gtkentry.c b/gtk/gtkentry.c
index b57a1ac..151de54 100644
--- a/gtk/gtkentry.c
+++ b/gtk/gtkentry.c
@@ -7151,6 +7151,7 @@ gtk_entry_set_buffer (GtkEntry *entry,
{
GtkEntryPrivate *priv;
GObject *obj;
+ gboolean had_buffer = FALSE;
g_return_if_fail (GTK_IS_ENTRY (entry));
@@ -7164,6 +7165,7 @@ gtk_entry_set_buffer (GtkEntry *entry,
if (priv->buffer)
{
+ had_buffer = TRUE;
buffer_disconnect_signals (entry);
g_object_unref (priv->buffer);
}
@@ -7184,8 +7186,11 @@ gtk_entry_set_buffer (GtkEntry *entry,
g_object_notify_by_pspec (obj, entry_props[PROP_INVISIBLE_CHAR_SET]);
g_object_thaw_notify (obj);
- gtk_editable_set_position (GTK_EDITABLE (entry), 0);
- gtk_entry_recompute (entry);
+ if (had_buffer)
+ {
+ gtk_editable_set_position (GTK_EDITABLE (entry), 0);
+ gtk_entry_recompute (entry);
+ }
}
/**
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]