[gtk+] appchooser: Plug a memory leak



commit 34e26017e3c2432a6675e5ce6a1c64163a05e4fb
Author: Matthias Clasen <mclasen redhat com>
Date:   Mon Nov 14 14:19:58 2016 -0500

    appchooser: Plug a memory leak
    
    We were not dropping the reference that the model gives us.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774352

 gtk/gtkappchooserwidget.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/gtk/gtkappchooserwidget.c b/gtk/gtkappchooserwidget.c
index f45348e..9a4103a 100644
--- a/gtk/gtkappchooserwidget.c
+++ b/gtk/gtkappchooserwidget.c
@@ -161,17 +161,17 @@ refresh_and_emit_app_selected (GtkAppChooserWidget *self,
       if (!g_app_info_equal (self->priv->selected_app_info, info))
         {
           should_emit = TRUE;
-          g_object_unref (self->priv->selected_app_info);
-
-          self->priv->selected_app_info = info;
+          g_set_object (&self->priv->selected_app_info, info);
         }
     }
   else
     {
       should_emit = TRUE;
-      self->priv->selected_app_info = info;
+      g_set_object (&self->priv->selected_app_info, info);
     }
 
+  g_object_unref (info);
+
   if (should_emit)
     g_signal_emit (self, signals[SIGNAL_APPLICATION_SELECTED], 0,
                    self->priv->selected_app_info);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]