[shotwell/shotwell-0.24] thumbnailer: fix double close()



commit 22830bd4347fd9e7c9ae691a3ff37baa52f480f1
Author: Damian Pietras <bug1 daper net>
Date:   Mon Nov 7 13:29:00 2016 +0000

    thumbnailer: fix double close()
    
    A file descriptor used to communicate with the video thumbnailer process is
    closed twice. In case another thread allocates the same descriptor number in
    the meantime, the second close() actually closes a descriptor not owned by the
    thread. This causes crashes in most cases or unexpected behaviour.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=774057

 src/VideoSupport.vala |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/src/VideoSupport.vala b/src/VideoSupport.vala
index 6543cf5..e2d5384 100644
--- a/src/VideoSupport.vala
+++ b/src/VideoSupport.vala
@@ -264,7 +264,6 @@ public class VideoReader {
             buf = null;
         }
         
-        Posix.close(child_stdout);
         GLib.Process.close_pid(thumbnailer_pid);
         thumbnailer_pid = 0;
         return buf;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]