[shotwell] thumbnailer: fix double close()
- From: Jens Georg <jensgeorg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [shotwell] thumbnailer: fix double close()
- Date: Mon, 7 Nov 2016 20:57:51 +0000 (UTC)
commit d5c9ffb6e430ce641c657e390107311e105671f5
Author: Damian Pietras <bug1 daper net>
Date: Mon Nov 7 13:29:00 2016 +0000
thumbnailer: fix double close()
A file descriptor used to communicate with the video thumbnailer process is
closed twice. In case another thread allocates the same descriptor number in
the meantime, the second close() actually closes a descriptor not owned by the
thread. This causes crashes in most cases or unexpected behaviour.
https://bugzilla.gnome.org/show_bug.cgi?id=774057
src/VideoSupport.vala | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/src/VideoSupport.vala b/src/VideoSupport.vala
index 791a12a..540aad4 100644
--- a/src/VideoSupport.vala
+++ b/src/VideoSupport.vala
@@ -264,7 +264,6 @@ public class VideoReader {
buf = null;
}
- Posix.close(child_stdout);
GLib.Process.close_pid(thumbnailer_pid);
thumbnailer_pid = 0;
return buf;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]