[network-manager-applet] editor: fix invalid memory access when displaying service details
- From: Beniamino Galvani <bgalvani src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-applet] editor: fix invalid memory access when displaying service details
- Date: Mon, 7 Nov 2016 15:29:18 +0000 (UTC)
commit 7c080df78187614d03949e2eb9120f66eb1b3811
Author: Beniamino Galvani <bgalvani redhat com>
Date: Mon Nov 7 16:18:40 2016 +0100
editor: fix invalid memory access when displaying service details
If the plugin returns an empty detail list, we would access past the
array in:
i_add_detail = (++add_details)[0];
Fixes: 9ab2f79b673b37b83b358eddad68bb442d7e16e4
src/connection-editor/connection-helpers.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/connection-editor/connection-helpers.c b/src/connection-editor/connection-helpers.c
index 85261ef..e8cc615 100644
--- a/src/connection-editor/connection-helpers.c
+++ b/src/connection-editor/connection-helpers.c
@@ -345,7 +345,7 @@ set_up_connection_type_combo (GtkComboBox *combo,
g_free (markup);
i_next:
- if (!add_details)
+ if (!i_add_detail)
break;
i_add_detail = (++add_details)[0];
} while (i_add_detail);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]