[gnome-software/wip/kalev/gnome-3-22-prep: 9/52] trivial: Add a sanity check in the GsAppList duplicate check



commit ba8ecbcd55dee926a88cfeb03dcb6f0bfaf07bc6
Author: Richard Hughes <richard hughsie com>
Date:   Fri Sep 16 09:59:28 2016 +0100

    trivial: Add a sanity check in the GsAppList duplicate check
    
    This shouldn't be triggering, but is. Futher investigation required...
    
    (cherry picked from commit 3e2755a984e39cc5a34cb39969c784d4a7098fcb)

 src/gs-app-list.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
---
diff --git a/src/gs-app-list.c b/src/gs-app-list.c
index c22c397..29ebe87 100644
--- a/src/gs-app-list.c
+++ b/src/gs-app-list.c
@@ -87,6 +87,13 @@ gs_app_list_check_for_duplicate (GsAppList *list, GsApp *app)
                return TRUE;
        }
 
+       /* do a sanity check */
+       if (!as_utils_unique_id_equal (id, id_old)) {
+               g_debug ("unique-id non-equal %s as %s but hash matched!",
+                        id, id_old);
+               return TRUE;
+       }
+
        /* already exists */
        g_debug ("not adding duplicate %s as %s already exists", id, id_old);
        return FALSE;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]