[tracker] libtracker-miner: Start TrackerDecorator queries on TrackerMiner::started
- From: Carlos Garnacho <carlosg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [tracker] libtracker-miner: Start TrackerDecorator queries on TrackerMiner::started
- Date: Thu, 3 Nov 2016 13:52:15 +0000 (UTC)
commit 2c86dd8710cda2b01e1ba2105c1e0d5a2d388484
Author: Carlos Garnacho <carlosg gnome org>
Date: Tue Nov 1 15:55:20 2016 +0100
libtracker-miner: Start TrackerDecorator queries on TrackerMiner::started
This should not be done in the initable vfunc, as the miner should remain
idle until tracker_miner_start() is called on it.
This fixes a possible race condition in tracker-extract, where this query
is already in flight at the time TrackerPersistence handles blacklisting
of files that caused earlier crashes of tracker-extract. So the query might
contain the file that's being blacklisted right away. tracker_miner_start()
is called after TrackerPersistence did the blacklisting job, so the first
query will get the up-to-date info.
src/libtracker-miner/tracker-decorator.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/src/libtracker-miner/tracker-decorator.c b/src/libtracker-miner/tracker-decorator.c
index 55f5f71..1ac319a 100644
--- a/src/libtracker-miner/tracker-decorator.c
+++ b/src/libtracker-miner/tracker-decorator.c
@@ -1215,7 +1215,6 @@ tracker_decorator_initable_init (GInitable *initable,
class_signal_cb,
initable, NULL);
decorator_update_state (decorator, "Idle", FALSE);
- decorator_rebuild_cache (decorator);
return TRUE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]