[gnome-software] Always request the icon for the overview shell

[Richard Hughes <rhughes src gnome org>]

commit b5bed5e9a0d2006978420d111975168c14412a98
Author: Richard Hughes <richard hughsie com>
Date:   Fri May 27 14:40:31 2016 +0100

    Always request the icon for the overview shell
    
    This worked before as AppStream unconditionally set one.

 src/gs-self-test.c      |    5 +++--
 src/gs-shell-overview.c |    6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/src/gs-self-test.c b/src/gs-self-test.c
index f9332e3..15e2277 100644
--- a/src/gs-self-test.c
+++ b/src/gs-self-test.c
@@ -445,6 +445,7 @@ gs_plugin_loader_installed_func (GsPluginLoader *plugin_loader)
                                               GS_PLUGIN_REFINE_FLAGS_REQUIRE_ADDONS |
                                               GS_PLUGIN_REFINE_FLAGS_REQUIRE_LICENSE |
                                               GS_PLUGIN_REFINE_FLAGS_REQUIRE_MENU_PATH |
+                                              GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON |
                                               GS_PLUGIN_REFINE_FLAGS_REQUIRE_PROVENANCE,
                                               NULL,
                                               &error);
@@ -504,7 +505,7 @@ gs_plugin_loader_search_func (GsPluginLoader *plugin_loader)
        /* get search result based on addon keyword */
        list = gs_plugin_loader_search (plugin_loader,
                                        "spell",
-                                       GS_PLUGIN_REFINE_FLAGS_DEFAULT,
+                                       GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON,
                                        NULL,
                                        &error);
        g_assert_no_error (error);
@@ -739,7 +740,7 @@ gs_plugin_loader_flatpak_func (GsPluginLoader *plugin_loader)
        /* find available application */
        list = gs_plugin_loader_search (plugin_loader,
                                        "Bingo",
-                                       GS_PLUGIN_REFINE_FLAGS_DEFAULT,
+                                       GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON,
                                        NULL,
                                        &error);
        g_assert_no_error (error);
diff --git a/src/gs-shell-overview.c b/src/gs-shell-overview.c
index 47fd9ca..8251ec7 100644
--- a/src/gs-shell-overview.c
+++ b/src/gs-shell-overview.c
@@ -398,7 +398,7 @@ gs_shell_overview_load (GsShellOverview *self)
        if (!priv->loading_featured) {
                priv->loading_featured = TRUE;
                gs_plugin_loader_get_featured_async (priv->plugin_loader,
-                                                    GS_PLUGIN_REFINE_FLAGS_DEFAULT,
+                                                    GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON,
                                                     priv->cancellable,
                                                     gs_shell_overview_get_featured_cb,
                                                     self);
@@ -408,7 +408,7 @@ gs_shell_overview_load (GsShellOverview *self)
        if (!priv->loading_popular) {
                priv->loading_popular = TRUE;
                gs_plugin_loader_get_popular_async (priv->plugin_loader,
-                                                   GS_PLUGIN_REFINE_FLAGS_DEFAULT,
+                                                   GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON,
                                                    priv->cancellable,
                                                    gs_shell_overview_get_popular_cb,
                                                    self);
@@ -431,7 +431,7 @@ gs_shell_overview_load (GsShellOverview *self)
                priv->loading_popular_rotating = TRUE;
                gs_plugin_loader_get_category_apps_async (priv->plugin_loader,
                                                          featured_category,
-                                                         GS_PLUGIN_REFINE_FLAGS_DEFAULT,
+                                                         GS_PLUGIN_REFINE_FLAGS_REQUIRE_ICON,
                                                          priv->cancellable,
                                                          gs_shell_overview_get_popular_rotating_cb,
                                                          load_data);