[gnome-software] trivial: Do not set the state from AppStream metadata

[Richard Hughes <rhughes src gnome org>]

commit d540278d8fd4dfcdfedede9bf6b00d41c954a154
Author: Richard Hughes <richard hughsie com>
Date:   Thu May 26 15:16:25 2016 +0100

    trivial: Do not set the state from AppStream metadata
    
    We know what applications are installed (as they have a source-kind of APPDATA)
    but it's not safe to proxy the state when removing applications.
    
    I guess this is an appstream-glib bug where we're not resetting the state when
    we move from AppData-to-AppStream but it seems overly fragile to rely on this
    alone.

 src/plugins/gs-appstream.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/src/plugins/gs-appstream.c b/src/plugins/gs-appstream.c
index 23f93bb..e53b199 100644
--- a/src/plugins/gs-appstream.c
+++ b/src/plugins/gs-appstream.c
@@ -420,14 +420,9 @@ gs_appstream_refine_app (GsPlugin *plugin,
                switch (as_app_get_source_kind (item)) {
                case AS_APP_SOURCE_KIND_APPDATA:
                case AS_APP_SOURCE_KIND_DESKTOP:
-                       gs_app_set_state (app, AS_APP_STATE_INSTALLED);
-                       break;
                case AS_APP_SOURCE_KIND_METAINFO:
                        gs_app_set_state (app, AS_APP_STATE_INSTALLED);
                        break;
-               case AS_APP_SOURCE_KIND_APPSTREAM:
-                       gs_app_set_state (app, as_app_get_state (item));
-                       break;
                default:
                        break;
                }