[gnome-software] Fix the distro upgrade errors to show up



commit 07318d69df70ab96deb1aa81b6b9f1598c8579a3
Author: Kalev Lember <klember redhat com>
Date:   Thu May 26 14:06:11 2016 +0200

    Fix the distro upgrade errors to show up
    
    Show the actual error instead of an unhelpful "no plugin could handle
    gs_plugin_app_upgrade_download".

 src/gs-shell-updates.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
---
diff --git a/src/gs-shell-updates.c b/src/gs-shell-updates.c
index fca59bb..bab82a1 100644
--- a/src/gs-shell-updates.c
+++ b/src/gs-shell-updates.c
@@ -1051,17 +1051,11 @@ upgrade_download_finished_cb (GObject *source,
        g_autoptr(GsPageHelper) helper = (GsPageHelper *) user_data;
 
        if (!gs_plugin_loader_app_action_finish (plugin_loader, res, &error)) {
-               g_warning ("failed to upgrade-download: %s", error->message);
                if (g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED))
                        return;
-               gs_app_notify_failed_modal (helper->app,
-                                           gs_shell_get_window (helper->self->shell),
-                                           GS_PLUGIN_LOADER_ACTION_UPGRADE_DOWNLOAD,
-                                           error);
-               return;
+               g_warning ("failed to upgrade-download: %s", error->message);
        }
 
-       /* non-fatal error */
        last_error = gs_app_get_last_error (helper->app);
        if (last_error != NULL) {
                g_warning ("failed to upgrade-download %s: %s",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]