[glade/glade-3-20] GladeGtkListBox: Fix "format not a string literal" warning



commit 111eb2d9854edb621dc3edac7372d7aac89a60a2
Author: Bastien Nocera <hadess hadess net>
Date:   Tue Apr 26 15:20:25 2016 +0200

    GladeGtkListBox: Fix "format not a string literal" warning
    
    glade-gtk-list-box.c: In function ‘glade_gtk_listbox_child_insert_action’:
    glade-gtk-list-box.c:208:3: error: format not a string literal, argument types not checked 
[-Werror=format-nonliteral]
       glade_command_push_group (group_format, glade_widget_get_name (parent));
       ^~~~~~~~~~~~~~~~~~~~~~~~
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765612

 plugins/gtk+/glade-gtk-list-box.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
---
diff --git a/plugins/gtk+/glade-gtk-list-box.c b/plugins/gtk+/glade-gtk-list-box.c
index fcd485a..94a6dcd 100644
--- a/plugins/gtk+/glade-gtk-list-box.c
+++ b/plugins/gtk+/glade-gtk-list-box.c
@@ -197,7 +197,6 @@ static void
 glade_gtk_listbox_child_insert_action (GladeWidgetAdaptor *adaptor,
                                        GObject            *container,
                                        GObject            *object,
-                                       const gchar        *group_format,
                                        gboolean            after)
 {
   GladeWidget *parent;
@@ -205,7 +204,7 @@ glade_gtk_listbox_child_insert_action (GladeWidgetAdaptor *adaptor,
   gint position;
 
   parent = glade_widget_get_from_gobject (container);
-  glade_command_push_group (group_format, glade_widget_get_name (parent));
+  glade_command_push_group (_("Insert Row on %s"), glade_widget_get_name (parent));
 
   position = gtk_list_box_row_get_index (GTK_LIST_BOX_ROW (object));
   if (after)
@@ -249,13 +248,11 @@ glade_gtk_listbox_child_action_activate (GladeWidgetAdaptor *adaptor,
   if (strcmp (action_path, "insert_after") == 0)
     {
       glade_gtk_listbox_child_insert_action (adaptor, container, object,
-                                             _("Insert Row on %s"),
                                              TRUE);
     }
   else if (strcmp (action_path, "insert_before") == 0)
     {
       glade_gtk_listbox_child_insert_action (adaptor, container, object,
-                                             _("Insert Row on %s"),
                                              FALSE);
     }
   else


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]