[geary/geary-0.11] Use HTTPS for accessing Gravatar.com
- From: Michael Gratton <mjog src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [geary/geary-0.11] Use HTTPS for accessing Gravatar.com
- Date: Wed, 18 May 2016 13:17:42 +0000 (UTC)
commit e0afb958b6cef4d90a1970964aa5043091aff4f8
Author: Ville Korhonen <ville xd fi>
Date: Wed May 18 10:10:39 2016 +0300
Use HTTPS for accessing Gravatar.com
Prevents leaking MD5 hashes of e-mails user is receiving mail from,
which could potentially leak information leading to
a) identifying the user
b) identifying people user communicates with
See <https://en.gravatar.com/site/implement/images/#secure-images> for
upstream documentation of HTTPS implementation.
Bug 766595
src/client/util/util-gravatar.vala | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/client/util/util-gravatar.vala b/src/client/util/util-gravatar.vala
index 641dcf1..c221ced 100644
--- a/src/client/util/util-gravatar.vala
+++ b/src/client/util/util-gravatar.vala
@@ -57,7 +57,7 @@ public string get_image_uri(Geary.RFC822.MailboxAddress addr, Default def, int s
// http://en.gravatar.com/site/implement/hash/
string md5 = Checksum.compute_for_string(ChecksumType.MD5, addr.address.strip().down());
- return "http://www.gravatar.com/avatar/%s?d=%s&s=%d".printf(md5, def.to_param(), size);
+ return "https://secure.gravatar.com/avatar/%s?d=%s&s=%d".printf(md5, def.to_param(), size);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]