[gnome-builder/gnome-builder-3-20] launcher: remove freeze check
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder/gnome-builder-3-20] launcher: remove freeze check
- Date: Mon, 9 May 2016 10:28:23 +0000 (UTC)
commit 806745bb6977f49ee6404991b30daf97cb6ce536
Author: Christian Hergert <chergert redhat com>
Date: Mon May 9 13:26:00 2016 +0300
launcher: remove freeze check
We don't really need to freeze the launcher, as long as the consumer
doesn't use it from multiple threads simultaneously.
libide/ide-subprocess-launcher.c | 29 -----------------------------
1 files changed, 0 insertions(+), 29 deletions(-)
---
diff --git a/libide/ide-subprocess-launcher.c b/libide/ide-subprocess-launcher.c
index 1006a6c..958c02b 100644
--- a/libide/ide-subprocess-launcher.c
+++ b/libide/ide-subprocess-launcher.c
@@ -30,7 +30,6 @@
typedef struct
{
GSubprocessFlags flags;
- guint freeze_check : 1;
GPtrArray *argv;
gchar *cwd;
@@ -162,8 +161,6 @@ ide_subprocess_launcher_real_spawn_sync (IdeSubprocessLauncher *self,
g_assert (IDE_IS_SUBPROCESS_LAUNCHER (self));
g_assert (!cancellable || G_IS_CANCELLABLE (cancellable));
- priv->freeze_check = TRUE;
-
task = g_task_new (self, cancellable, NULL, NULL);
g_task_run_in_thread_sync (task, ide_subprocess_launcher_spawn_worker);
@@ -182,8 +179,6 @@ ide_subprocess_launcher_real_spawn_async (IdeSubprocessLauncher *self,
g_assert (IDE_IS_SUBPROCESS_LAUNCHER (self));
g_assert (!cancellable || G_IS_CANCELLABLE (cancellable));
- priv->freeze_check = TRUE;
-
task = g_task_new (self, cancellable, callback, user_data);
g_task_run_in_thread (task, ide_subprocess_launcher_spawn_worker);
}
@@ -326,12 +321,6 @@ ide_subprocess_launcher_set_flags (IdeSubprocessLauncher *self,
g_return_if_fail (IDE_IS_SUBPROCESS_LAUNCHER (self));
- if (priv->freeze_check)
- {
- g_warning ("process launcher is already frozen");
- return;
- }
-
if (flags != priv->flags)
{
priv->flags = flags;
@@ -368,12 +357,6 @@ ide_subprocess_launcher_set_environ (IdeSubprocessLauncher *self,
g_return_if_fail (IDE_IS_SUBPROCESS_LAUNCHER (self));
- if (priv->freeze_check)
- {
- g_warning ("process launcher is already frozen");
- return;
- }
-
g_ptr_array_remove_range (priv->environ, 0, priv->environ->len);
if (environ_ != NULL)
@@ -398,12 +381,6 @@ ide_subprocess_launcher_setenv (IdeSubprocessLauncher *self,
g_return_if_fail (IDE_IS_SUBPROCESS_LAUNCHER (self));
g_return_if_fail (key != NULL);
- if (priv->freeze_check)
- {
- g_warning ("process launcher is already frozen");
- return;
- }
-
if (value == NULL)
value = "";
@@ -443,12 +420,6 @@ ide_subprocess_launcher_push_argv (IdeSubprocessLauncher *self,
g_return_if_fail (IDE_IS_SUBPROCESS_LAUNCHER (self));
g_return_if_fail (argv != NULL);
- if (priv->freeze_check)
- {
- g_warning ("process launcher is already frozen");
- return;
- }
-
g_ptr_array_index (priv->argv, priv->argv->len - 1) = g_strdup (argv);
g_ptr_array_add (priv->argv, NULL);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]