[gtk+/gtk-3-20] wayland: Ignore NoSymbol keys



commit 0e44b8c38cf976a726d946112f613f83f3fb209c
Author: Daniel Stone <daniels collabora com>
Date:   Wed Apr 27 14:06:38 2016 +0200

    wayland: Ignore NoSymbol keys
    
    NoSymbol is not a valid GDK symbol (it only has the concept of
    VoidSymbol, for some reason, which is neither the same thing nor
    produced by any sane keymap). Passing NoSymbol events through to GTK+
    apps is unlikely to produce anything useful.
    
    In particular, this meant VTE would scroll to the end of the buffer when
    pressing Fn (required for Page Up/Down on Macs), as it was receiving a
    keypress that wasn't a modifeir. This does not happen on X11, as the
    KEY_FN keycode is above 255, so does not get sent to clients.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=764825

 gdk/wayland/gdkdevice-wayland.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/gdk/wayland/gdkdevice-wayland.c b/gdk/wayland/gdkdevice-wayland.c
index dfe62d7..11b2f69 100644
--- a/gdk/wayland/gdkdevice-wayland.c
+++ b/gdk/wayland/gdkdevice-wayland.c
@@ -1738,6 +1738,8 @@ deliver_key_event (GdkWaylandSeat *seat,
   xkb_keymap = _gdk_wayland_keymap_get_xkb_keymap (keymap);
 
   sym = xkb_state_key_get_one_sym (xkb_state, key);
+  if (sym == XKB_KEY_NoSymbol)
+    return;
 
   if (sym == XKB_KEY_NoSymbol)
     return;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]