[gnome-online-accounts] imap-smtp: Fix add_account() leak



commit ce26bcb781df49e11893193438f991af9fe8f3e8
Author: Christophe Fergeau <cfergeau redhat com>
Date:   Mon Mar 28 22:07:18 2016 +0200

    imap-smtp: Fix add_account() leak
    
    While at it, fix the same leak in refresh_account()
    
    ==9457== 11 bytes in 1 blocks are definitely lost in loss record 972 of 23,129
    ==9457==    at 0x4C28BF6: malloc (vg_replace_malloc.c:299)
    ==9457==    by 0x1456711C: g_malloc (gmem.c:94)
    ==9457==    by 0x145673FE: g_malloc_n (gmem.c:331)
    ==9457==    by 0x14581DCE: g_strdup (gstrfuncs.c:363)
    ==9457==    by 0x5BE4A17: goa_utils_parse_email_address (goautils.c:557)
    ==9457==    by 0x5BD62A5: add_account (goaimapsmtpprovider.c:1084)
    ==9457==    by 0x5BBD6A1: goa_provider_add_account (goaprovider.c:382)
    ==9457==    by 0x49C7D1: add_account_dialog_add_account (cc-online-accounts-add-account-dialog.c:83)
    ==9457==    by 0x49C864: list_box_row_activated_cb (cc-online-accounts-add-account-dialog.c:102)
    ==9457==    by 0x142CC6D4: g_cclosure_marshal_VOID__OBJECTv (gmarshal.c:2102)
    ==9457==    by 0x142C7C43: _g_closure_invoke_va (gclosure.c:867)
    ==9457==    by 0x142E2524: g_signal_emit_valist (gsignal.c:3294)
    ==9457==    by 0x142E369C: g_signal_emit (gsignal.c:3441)
    ==9457==    by 0x1264EAF2: gtk_list_box_activate (gtklistbox.c:1754)
    ==9457==    by 0x1264EB4B: gtk_list_box_select_and_activate_full (gtklistbox.c:1768)
    ==9457==    by 0x1264F115: gtk_list_box_multipress_gesture_released (gtklistbox.c:1964)
    ==9457==    by 0x1D52AD2F: ffi_call_unix64 (unix64.S:76)
    ==9457==    by 0x1D52A79A: ffi_call (ffi64.c:525)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=764283

 src/goabackend/goaimapsmtpprovider.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/src/goabackend/goaimapsmtpprovider.c b/src/goabackend/goaimapsmtpprovider.c
index 01acd39..c998747 100644
--- a/src/goabackend/goaimapsmtpprovider.c
+++ b/src/goabackend/goaimapsmtpprovider.c
@@ -1106,6 +1106,7 @@ add_account (GoaProvider    *provider,
       gtk_widget_show_all (data.cluebar);
 
       g_clear_object (&smtp_auth);
+      g_clear_pointer (&domain, g_free);
       goto smtp_again;
     }
 
@@ -1422,6 +1423,7 @@ refresh_account (GoaProvider    *provider,
       gtk_widget_show_all (data.cluebar);
 
       g_clear_object (&smtp_auth);
+      g_clear_pointer (&domain, g_free);
       goto smtp_again;
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]