[gimp-perl] reduce hardcoding



commit 2281870116079b87216fb1534b8f98cb11503d6c
Author: Ed J <edj src gnome org>
Date:   Mon May 2 05:32:57 2016 +0100

    reduce hardcoding

 Changes          |    5 +++++
 t/02-netplugin.t |    7 ++++---
 2 files changed, 9 insertions(+), 3 deletions(-)
---
diff --git a/Changes b/Changes
index 8cf0ece..926cbb9 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 Revision history for Perl module Gimp
 
+2.31_02 2016-05-02
+
+    Bug fixes:
+    - reduce hardcoding in t/02-netplugin.t
+
 2.31_01 2016-05-01
 
     API:
diff --git a/t/02-netplugin.t b/t/02-netplugin.t
index e5f1312..da7f2b9 100644
--- a/t/02-netplugin.t
+++ b/t/02-netplugin.t
@@ -1,15 +1,16 @@
 use strict;
 use Test::More;
 our ($dir, $DEBUG);
+my @PLUGINS;
 BEGIN {
 #  $Gimp::verbose = 3;
+  @PLUGINS = qw(dots glowing_steel map_to_gradient redeye);
   $DEBUG = 0;
   require 't/gimpsetup.pl';
   # most minimal and elegant would be to symlink sandbox gimp-dir's
   # plug-ins to our blib/plugins dir, but not portable to windows
   my $blibdir = 'blib/plugins';
-  my @plugins = map { "$blibdir/$_" }
-    qw(dots glowing_steel map_to_gradient redeye);
+  my @plugins = map { "$blibdir/$_" } @PLUGINS;
   map {
     warn "inst $_\n" if $Gimp::verbose;
     write_plugin($DEBUG, $_, io($_)->all);
@@ -28,7 +29,7 @@ use IO::Select; # needed because output can be big and it can block!
 our (@testbench, %proc2file, %file2procs);
 require 't/examples-api.pl';
 
-my %plug2yes = map { ($_=>1) } qw(dots glowing_steel map_to_gradient red_eye);
+my %plug2yes = map { ($_=>1) } @PLUGINS;
 @testbench = grep { $plug2yes{$_->[0]} } @testbench;
 my @duptest = @{$testbench[0]};
 $duptest[3] = [ @{$duptest[3]} ]; # don't change original


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]