[meld/Python3: 19/54] recent: "Fix" a py3k problem by punting it to later



commit 6b76c19baeefe17813ab3328b148fcf15400a306
Author: Kai Willadsen <kai willadsen gmail com>
Date:   Sat Nov 14 07:00:30 2015 +1000

    recent: "Fix" a py3k problem by punting it to later

 meld/recent.py |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
---
diff --git a/meld/recent.py b/meld/recent.py
index 9f19d5e..926ab66 100644
--- a/meld/recent.py
+++ b/meld/recent.py
@@ -154,7 +154,11 @@ class RecentFiles(object):
         return comp_type, paths, flags
 
     def _write_recent_file(self, comp_type, paths):
-        paths = [p.encode(sys.getfilesystemencoding()) for p in paths]
+        # FIXME: Commenting out this line is 100% incorrect. We need to
+        # be storing bytestrings here, but the configparser API doesn't
+        # like this. This code *will* eventually break.
+        # paths = [p.encode(sys.getfilesystemencoding()) for p in paths]
+
         # TODO: Use GKeyFile instead, and return a Gio.File. This is why we're
         # using ';' to join comparison paths.
         with tempfile.NamedTemporaryFile(


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]