[gtk+] GDK W32: Print error code along with the error message
- From: Руслан Ижбулатов <ruslanizhb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] GDK W32: Print error code along with the error message
- Date: Fri, 25 Mar 2016 22:08:23 +0000 (UTC)
commit 692c3b11ff3877de90b653536d13dafc4e879ab8
Author: Руслан Ижбулатов <lrn1986 gmail com>
Date: Mon Mar 21 16:25:19 2016 +0000
GDK W32: Print error code along with the error message
Error codes can be easily looked up in an error code list
and/or googled up. Error messages, while descriptive, often
describe the wrong thing, and the messages themselves are not
part of the documentation of a function, unlike error codes.
It would be preferable to have the code, or both.
https://bugzilla.gnome.org/show_bug.cgi?id=763913
gdk/win32/gdkmain-win32.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/gdk/win32/gdkmain-win32.c b/gdk/win32/gdkmain-win32.c
index a8a7650..b170612 100644
--- a/gdk/win32/gdkmain-win32.c
+++ b/gdk/win32/gdkmain-win32.c
@@ -134,10 +134,11 @@ _gdk_win32_windowing_init (void)
void
_gdk_win32_api_failed (const gchar *where,
- const gchar *api)
+ const gchar *api)
{
- gchar *msg = g_win32_error_message (GetLastError ());
- g_warning ("%s: %s failed: %s", where, api, msg);
+ DWORD error_code = GetLastError ();
+ gchar *msg = g_win32_error_message (error_code);
+ g_warning ("%s: %s failed with code %lu: %s", where, api, error_code, msg);
g_free (msg);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]