[epiphany/wip/fixes: 8/15] Improve some FIXMEs



commit fff5e08b204896fbeca5773137226e841cd50800
Author: Michael Catanzaro <mcatanzaro igalia com>
Date:   Sat Mar 5 13:05:00 2016 -0600

    Improve some FIXMEs
    
     * Let's not rename downloaded files
     * g_application_get_application_id is a thing
    
    https://bugzilla.gnome.org/show_bug.cgi?id=610586

 embed/ephy-embed-shell.c |    6 +++---
 lib/ephy-file-helpers.c  |    1 -
 2 files changed, 3 insertions(+), 4 deletions(-)
---
diff --git a/embed/ephy-embed-shell.c b/embed/ephy-embed-shell.c
index f83f851..5777cc9 100644
--- a/embed/ephy-embed-shell.c
+++ b/embed/ephy-embed-shell.c
@@ -1141,9 +1141,9 @@ ephy_embed_shell_launch_handler (EphyEmbedShell *shell,
   /* Do not allow recursive calls into the browser, they can lead to
    * infinite loops and they should never happen anyway. */
 
-  /* FIXME: eventually there should be a nice and safe way of getting
-   * the app ID from the GApplication itself, but for now let's
-   * hardcode the .desktop file name and use it here. */
+  /* FIXME: Should use g_application_get_application_id() here instead of
+   * hardcoding epiphany.desktop. But first, we have to rename the desktop file.
+   */
   if (!app || g_strcmp0 (g_app_info_get_id (app), "epiphany.desktop") == 0)
     return ret;
 
diff --git a/lib/ephy-file-helpers.c b/lib/ephy-file-helpers.c
index 1c828cf..69de134 100644
--- a/lib/ephy-file-helpers.c
+++ b/lib/ephy-file-helpers.c
@@ -788,7 +788,6 @@ ephy_file_launcher_get_app_info_for_file (GFile *file,
                if (type != NULL && type[0] != '\0' &&
                    ephy_file_check_mime (type) == EPHY_MIME_PERMISSION_SAFE)
                {
-                       /* FIXME rename tmp file to right extension ? */
                        app = g_app_info_get_default_for_type (type, FALSE);
                }
                g_free (type);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]