[epiphany/wip/fixes: 4/15] web-view: Never request snapshots when favicon is received

[Michael Catanzaro <mcatanzaro src gnome org>]

commit eb5db04c58d39b823aea65c6abd7ac71edd661f7
Author: Michael Catanzaro <mcatanzaro igalia com>
Date:   Fri Feb 26 22:06:42 2016 -0600

    web-view: Never request snapshots when favicon is received
    
    It's too soon, it results in us getting completely white snapshots out
    of the snapshot service.
    
    This is hardly a "fix" I am proud of, but it works reliably, at least on
    my machine.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=761065

 embed/ephy-web-view.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)
---
diff --git a/embed/ephy-web-view.c b/embed/ephy-web-view.c
index a777a68..a731475 100644
--- a/embed/ephy-web-view.c
+++ b/embed/ephy-web-view.c
@@ -650,11 +650,6 @@ icon_changed_cb (EphyWebView *view,
                  GParamSpec *pspec,
                  gpointer user_data)
 {
-  if (view->snapshot_timeout_id == 0) {
-    view->snapshot_timeout_id = g_timeout_add_full (G_PRIORITY_LOW, 0,
-                                                          (GSourceFunc)web_view_check_snapshot,
-                                                          view, NULL);
-  }
   _ephy_web_view_update_icon (view);
 }
 
@@ -1527,8 +1522,8 @@ load_changed_cb (WebKitWebView *web_view,
     if (!ephy_web_view_is_history_frozen (view) &&
         ephy_embed_shell_get_mode (ephy_embed_shell_get_default ()) != EPHY_EMBED_SHELL_MODE_INCOGNITO) {
       if (!ephy_snapshot_service_lookup_snapshot_path (ephy_snapshot_service_get_default (), 
webkit_web_view_get_uri (web_view))) {
-        /* If the snapshot check hasn't been scheduled already by the favicon callback,
-         * check the snapshot if we don't get a favicon in 1 second
+        /* FIXME: The 1s delay is a workaround to allow time to render the page and get a favicon.
+         * https://bugzilla.gnome.org/show_bug.cgi?id=761065
          */
         if (view->snapshot_timeout_id == 0) {
           view->snapshot_timeout_id = g_timeout_add_seconds_full (G_PRIORITY_LOW, 1,