[gnome-software] Revert "Do not return failure from refresh when the shell extensions site is down"

[Richard Hughes <rhughes src gnome org>]

commit ec8d00b39fba58bb59feae063c0d897edac05f15
Author: Richard Hughes <richard hughsie com>
Date:   Fri Mar 4 09:20:04 2016 +0000

    Revert "Do not return failure from refresh when the shell extensions site is down"
    
    This reverts commit ae2ca81cc1c8956239e25c788b555d68845d61f4.

 src/plugins/gs-plugin-shell-extensions.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)
---
diff --git a/src/plugins/gs-plugin-shell-extensions.c b/src/plugins/gs-plugin-shell-extensions.c
index 0d3ecc4..8d5c8a7 100644
--- a/src/plugins/gs-plugin-shell-extensions.c
+++ b/src/plugins/gs-plugin-shell-extensions.c
@@ -682,19 +682,15 @@ gs_plugin_refresh (GsPlugin *plugin,
        g_autoptr(GPtrArray) apps = NULL;
        g_autoptr(AsStore) store = NULL;
        g_autoptr(GFile) file = NULL;
-       g_autoptr(GError) error_local = NULL;
 
        /* connect to gnome-shell */
        if (!gs_plugin_setup (plugin, cancellable, error))
                return FALSE;
 
-       /* get data, non-fatal if download failed */
-       apps = gs_plugin_shell_extensions_get_apps (plugin, cache_age, &error_local);
-       if (apps == NULL) {
-               g_warning ("failed to refresh list of shell updates: %s",
-                          error_local->message);
-               return TRUE;
-       }
+       /* get data */
+       apps = gs_plugin_shell_extensions_get_apps (plugin, cache_age, error);
+       if (apps == NULL)
+               return FALSE;
 
        /* add to local store */
        store = as_store_new ();