[gnome-software] Do not return failure from refresh when the shell extensions site is down



commit ae2ca81cc1c8956239e25c788b555d68845d61f4
Author: Richard Hughes <richard hughsie com>
Date:   Thu Mar 3 11:39:18 2016 +0000

    Do not return failure from refresh when the shell extensions site is down

 src/plugins/gs-plugin-shell-extensions.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)
---
diff --git a/src/plugins/gs-plugin-shell-extensions.c b/src/plugins/gs-plugin-shell-extensions.c
index 3220278..3541ef6 100644
--- a/src/plugins/gs-plugin-shell-extensions.c
+++ b/src/plugins/gs-plugin-shell-extensions.c
@@ -678,15 +678,19 @@ gs_plugin_refresh (GsPlugin *plugin,
        g_autoptr(GPtrArray) apps = NULL;
        g_autoptr(AsStore) store = NULL;
        g_autoptr(GFile) file = NULL;
+       g_autoptr(GError) error_local = NULL;
 
        /* connect to gnome-shell */
        if (!gs_plugin_setup (plugin, cancellable, error))
                return FALSE;
 
-       /* get data */
-       apps = gs_plugin_shell_extensions_get_apps (plugin, cache_age, error);
-       if (apps == NULL)
-               return FALSE;
+       /* get data, non-fatal if download failed */
+       apps = gs_plugin_shell_extensions_get_apps (plugin, cache_age, &error_local);
+       if (apps == NULL) {
+               g_warning ("failed to refresh list of shell updates: %s",
+                          error_local->message);
+               return TRUE;
+       }
 
        /* add to local store */
        store = as_store_new ();


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]