[evolution/wip/webkit2] Do not leak a GalView in a GalViewInstance
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution/wip/webkit2] Do not leak a GalView in a GalViewInstance
- Date: Wed, 2 Mar 2016 15:20:32 +0000 (UTC)
commit 1aec47d7fe042dbee8e3ea11d64ce6899a705e3b
Author: Milan Crha <mcrha redhat com>
Date: Fri Nov 13 12:52:53 2015 +0100
Do not leak a GalView in a GalViewInstance
The connect_view() method receives a copy or a new instance of the view
already, thus no need to add a reference to it. This leak has several
consequences, like in the Mail view the associated MessageList is not
freed due to the GalView holding a reference to it.
e-util/gal-view-instance.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/e-util/gal-view-instance.c b/e-util/gal-view-instance.c
index 26e01c3..109a5fa 100644
--- a/e-util/gal-view-instance.c
+++ b/e-util/gal-view-instance.c
@@ -142,7 +142,7 @@ connect_view (GalViewInstance *instance,
if (instance->current_view)
disconnect_view (instance);
- instance->current_view = g_object_ref (view);
+ instance->current_view = view;
view_class = GAL_VIEW_GET_CLASS (view);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]