[gnome-builder] app: add comment about necessary code cleanup



commit f8589d43b58826dc7eb40ac0b22b712f2bf07a99
Author: Christian Hergert <chergert redhat com>
Date:   Thu Jun 30 14:09:00 2016 -0700

    app: add comment about necessary code cleanup

 libide/application/ide-application.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)
---
diff --git a/libide/application/ide-application.c b/libide/application/ide-application.c
index 7514eb1..bf9a58e 100644
--- a/libide/application/ide-application.c
+++ b/libide/application/ide-application.c
@@ -716,6 +716,14 @@ ide_application_open_project (IdeApplication *self,
   g_return_val_if_fail (IDE_IS_APPLICATION (self), FALSE);
   g_return_val_if_fail (G_IS_FILE (file), FALSE);
 
+  /*
+   * TODO: I don't like how this works. We should move this to
+   *       be async anyway and possibly share it with the open
+   *       file async code. Additionally, it has a race condition
+   *       for situations where the context was not loaded
+   *       immediately (and that will always happen).
+   */
+
   if (!g_file_query_exists (file, NULL))
     return FALSE;
 
@@ -744,7 +752,7 @@ ide_application_open_project (IdeApplication *self,
 
   gtk_window_present (GTK_WINDOW (workbench));
 
-  if (ide_workbench_get_context(workbench) != NULL)
+  if (ide_workbench_get_context (workbench) != NULL)
     return TRUE;
   else
     return FALSE;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]