[gnome-builder/wip/chergert/headerbar] build-tools: avoid showing panels when building



commit b98c79aa7c14da9edcdbb5b117aaaa3c331c2d66
Author: Christian Hergert <chergert redhat com>
Date:   Sun Jun 26 15:42:44 2016 -0700

    build-tools: avoid showing panels when building
    
    It is really annoying to have to hide these panels when building, so we
    will avoid showing them by default now that we can get the majority of
    important information from the omnibar.

 plugins/build-tools/gbp-build-workbench-addin.c |   15 ++++++++++-----
 1 files changed, 10 insertions(+), 5 deletions(-)
---
diff --git a/plugins/build-tools/gbp-build-workbench-addin.c b/plugins/build-tools/gbp-build-workbench-addin.c
index b805705..90d86ce 100644
--- a/plugins/build-tools/gbp-build-workbench-addin.c
+++ b/plugins/build-tools/gbp-build-workbench-addin.c
@@ -178,13 +178,18 @@ gbp_build_workbench_addin_do_build (GbpBuildWorkbenchAddin *self,
                                      gbp_build_workbench_addin_save_all_cb,
                                      state);
 
-  /* Ensure the build output is visible */
-  /* XXX: we might want to find a way to add a "hold" on the panel
-   *      visibility so that it can be hidden after a timeout.
+  /*
+   * No need to focus the build output, since the user can show that
+   * from the omnibar relatively quickly. We just need to make sure
+   * it is visible should they choose to view it.
    */
   gtk_widget_show (GTK_WIDGET (self->build_log_panel));
-  ide_workbench_focus (workbench, GTK_WIDGET (self->build_log_panel));
-  ide_workbench_focus (workbench, GTK_WIDGET (self->panel));
+
+  /*
+   * There is also no need to show the build result panel immediately.
+   * We can display the panel when a diagnostic has been discovered.
+   * Otherwise, it doesn't provide any additional information.
+   */
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]