[gnome-photos] single-item-job: Remove redundant function call



commit fe0ee5946a22d0c58bb969f984833c24f219a58d
Author: Debarshi Ray <debarshir gnome org>
Date:   Wed Jun 22 16:19:30 2016 +0200

    single-item-job: Remove redundant function call
    
    Destroying a TrackerSparqlCursor is enough to close it. No need to
    explicitly close it.
    
    In the following patch, when we convert SingleItemJob to use a
    GAsyncResult based asynchronous API, we can't close the cursor like
    this. The GAsyncReadyCallback will be called in the next iteration of
    the GMainLoop, and strictly speaking we shouldn't call
    tracker_sparql_cursor_get* on a closed cursor. It works today, but
    might not work in the future.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=764086

 src/photos-single-item-job.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/src/photos-single-item-job.c b/src/photos-single-item-job.c
index bc6caea..ab0fc95 100644
--- a/src/photos-single-item-job.c
+++ b/src/photos-single-item-job.c
@@ -91,7 +91,6 @@ photos_single_item_job_cursor_next (GObject *source_object, GAsyncResult *res, g
 
  out:
   photos_single_item_job_emit_callback (self);
-  tracker_sparql_cursor_close (cursor);
   g_object_unref (self);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]