[gnome-online-accounts/gnome-3-18] Use g_clear_pointer wherever applicable
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-online-accounts/gnome-3-18] Use g_clear_pointer wherever applicable
- Date: Mon, 20 Jun 2016 15:15:41 +0000 (UTC)
commit 2cd8b28930170c4f550f83bfa48e499d297eecfc
Author: Debarshi Ray <debarshir gnome org>
Date: Fri Jan 22 17:27:58 2016 +0100
Use g_clear_pointer wherever applicable
src/daemon/goadaemon.c | 7 ++-----
src/daemon/main.c | 6 ++----
src/goabackend/goaexchangeprovider.c | 6 ++----
src/goabackend/goaimapsmtpprovider.c | 9 +++------
src/goabackend/goakerberosprovider.c | 8 ++------
src/goabackend/goalastfmprovider.c | 6 ++----
src/goabackend/goamediaserverprovider.c | 6 ++----
src/goabackend/goaoauth2provider.c | 3 +--
src/goabackend/goaoauthprovider.c | 9 +++------
src/goabackend/goaowncloudprovider.c | 6 ++----
10 files changed, 21 insertions(+), 45 deletions(-)
---
diff --git a/src/daemon/goadaemon.c b/src/daemon/goadaemon.c
index 6760c50..4ae13dc 100644
--- a/src/daemon/goadaemon.c
+++ b/src/daemon/goadaemon.c
@@ -954,9 +954,7 @@ get_all_providers_cb (GObject *source,
g_free (group);
g_free (id);
g_free (path);
- if (key_file != NULL)
- g_key_file_free (key_file);
-
+ g_clear_pointer (&key_file, (GDestroyNotify) g_key_file_free);
g_object_unref (data->daemon);
g_object_unref (data->manager);
g_object_unref (data->invocation);
@@ -1118,8 +1116,7 @@ on_account_handle_remove (GoaAccount *account,
out:
g_clear_object (&provider);
g_free (data);
- if (key_file != NULL)
- g_key_file_free (key_file);
+ g_clear_pointer (&key_file, (GDestroyNotify) g_key_file_free);
g_free (group);
g_free (path);
return TRUE; /* invocation was handled */
diff --git a/src/daemon/main.c b/src/daemon/main.c
index fd3242e..a04cc39 100644
--- a/src/daemon/main.c
+++ b/src/daemon/main.c
@@ -135,10 +135,8 @@ main (int argc,
g_object_unref (tp_linker);
if (name_owner_id != 0)
g_bus_unown_name (name_owner_id);
- if (loop != NULL)
- g_main_loop_unref (loop);
- if (opt_context != NULL)
- g_option_context_free (opt_context);
+ g_clear_pointer (&loop, (GDestroyNotify) g_main_loop_unref);
+ g_clear_pointer (&opt_context, (GDestroyNotify) g_option_context_free);
g_message ("goa-daemon version %s exiting", PACKAGE_VERSION);
diff --git a/src/goabackend/goaexchangeprovider.c b/src/goabackend/goaexchangeprovider.c
index 05c34b8..71a4693 100644
--- a/src/goabackend/goaexchangeprovider.c
+++ b/src/goabackend/goaexchangeprovider.c
@@ -754,8 +754,7 @@ add_account (GoaProvider *provider,
g_assert (ret != NULL);
g_free (data.account_object_path);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
if (ews_client != NULL)
g_object_unref (ews_client);
@@ -909,8 +908,7 @@ refresh_account (GoaProvider *provider,
g_propagate_error (error, data.error);
gtk_widget_destroy (dialog);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
if (ews_client != NULL)
g_object_unref (ews_client);
diff --git a/src/goabackend/goaimapsmtpprovider.c b/src/goabackend/goaimapsmtpprovider.c
index 92fe097..1b59832 100644
--- a/src/goabackend/goaimapsmtpprovider.c
+++ b/src/goabackend/goaimapsmtpprovider.c
@@ -471,8 +471,7 @@ ensure_credentials_sync (GoaProvider *provider,
g_free (smtp_password);
g_free (smtp_server);
g_free (smtp_username);
- if (credentials != NULL)
- g_variant_unref (credentials);
+ g_clear_pointer (&credentials, (GDestroyNotify) g_variant_unref);
return ret;
}
@@ -1186,8 +1185,7 @@ add_account (GoaProvider *provider,
g_free (domain);
g_free (data.account_object_path);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
g_clear_object (&imap_auth);
g_clear_object (&smtp_auth);
@@ -1472,8 +1470,7 @@ refresh_account (GoaProvider *provider,
g_free (imap_username);
g_free (smtp_server);
g_free (smtp_username);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
g_clear_object (&imap_auth);
g_clear_object (&smtp_auth);
diff --git a/src/goabackend/goakerberosprovider.c b/src/goabackend/goakerberosprovider.c
index 2b541ef..5f1b241 100644
--- a/src/goabackend/goakerberosprovider.c
+++ b/src/goabackend/goakerberosprovider.c
@@ -352,10 +352,7 @@ get_ticket_sync (GoaKerberosProvider *self,
out:
g_clear_object (&ticketing);
g_free (object_path);
-
- if (credentials != NULL)
- g_variant_unref (credentials);
-
+ g_clear_pointer (&credentials, (GDestroyNotify) g_variant_unref);
return ret;
}
@@ -1317,8 +1314,7 @@ start_over:
g_free (request.account_object_path);
g_free (principal);
g_free (principal_for_display);
- if (request.loop != NULL)
- g_main_loop_unref (request.loop);
+ g_clear_pointer (&request.loop, (GDestroyNotify) g_main_loop_unref);
return object;
}
diff --git a/src/goabackend/goalastfmprovider.c b/src/goabackend/goalastfmprovider.c
index 852c9a2..112479b 100644
--- a/src/goabackend/goalastfmprovider.c
+++ b/src/goabackend/goalastfmprovider.c
@@ -760,8 +760,7 @@ add_account (GoaProvider *provider,
g_free (data.access_token);
g_free (data.account_object_path);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
return ret;
}
@@ -891,8 +890,7 @@ refresh_account (GoaProvider *provider,
g_propagate_error (error, data.error);
gtk_widget_destroy (dialog);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_free (data.access_token);
g_clear_object (&data.cancellable);
return ret;
diff --git a/src/goabackend/goamediaserverprovider.c b/src/goabackend/goamediaserverprovider.c
index 67c572d..b0968da 100644
--- a/src/goabackend/goamediaserverprovider.c
+++ b/src/goabackend/goamediaserverprovider.c
@@ -216,8 +216,7 @@ ensure_credentials_sync (GoaProvider *provider,
ret = TRUE;
out:
- if (credentials != NULL)
- g_variant_unref (credentials);
+ g_clear_pointer (&credentials, (GDestroyNotify) g_variant_unref);
return ret;
}
@@ -529,8 +528,7 @@ add_account (GoaProvider *provider,
g_free (data.account_object_path);
g_free (data.friendly_name);
g_free (data.udn);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
return ret;
}
diff --git a/src/goabackend/goaoauth2provider.c b/src/goabackend/goaoauth2provider.c
index db086da..78d5c60 100644
--- a/src/goabackend/goaoauth2provider.c
+++ b/src/goabackend/goaoauth2provider.c
@@ -1548,8 +1548,7 @@ goa_oauth2_provider_get_access_token_sync (GoaOAuth2Provider *provider,
g_free (refresh_token);
g_free (old_refresh_token);
g_free (password);
- if (credentials != NULL)
- g_variant_unref (credentials);
+ g_clear_pointer (&credentials, (GDestroyNotify) g_variant_unref);
g_mutex_unlock (lock);
diff --git a/src/goabackend/goaoauthprovider.c b/src/goabackend/goaoauthprovider.c
index 47e2711..2e5007c 100644
--- a/src/goabackend/goaoauthprovider.c
+++ b/src/goabackend/goaoauthprovider.c
@@ -946,8 +946,7 @@ get_tokens_and_identity (GoaOAuthProvider *provider,
g_free (url);
g_free (data.oauth_verifier);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_free (data.access_token);
g_free (data.access_token_secret);
g_free (escaped_request_token);
@@ -1125,8 +1124,7 @@ goa_oauth_provider_add_account (GoaProvider *_provider,
g_free (access_token_secret);
g_free (session_handle);
g_free (data.account_object_path);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
return ret;
}
@@ -1499,8 +1497,7 @@ goa_oauth_provider_get_access_token_sync (GoaOAuthProvider *provider,
g_free (access_token_secret_for_refresh);
g_free (session_handle_for_refresh);
g_free (password);
- if (credentials != NULL)
- g_variant_unref (credentials);
+ g_clear_pointer (&credentials, (GDestroyNotify) g_variant_unref);
g_mutex_unlock (lock);
diff --git a/src/goabackend/goaowncloudprovider.c b/src/goabackend/goaowncloudprovider.c
index 2eeb09b..6db4965 100644
--- a/src/goabackend/goaowncloudprovider.c
+++ b/src/goabackend/goaowncloudprovider.c
@@ -904,8 +904,7 @@ add_account (GoaProvider *provider,
g_free (server);
g_free (uri);
g_free (data.account_object_path);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
g_clear_object (&http_client);
return ret;
@@ -1061,8 +1060,7 @@ refresh_account (GoaProvider *provider,
gtk_widget_destroy (dialog);
g_free (uri);
g_free (uri_webdav);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
g_clear_object (&http_client);
return ret;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]