[geary] Don't re-hlighlight search matches on search string change.

[Michael Gratton <mjog src gnome org>]

commit b4761a2251144bb1e661813cfb2a0e96359ea349
Author: Michael James Gratton <mike vee net>
Date:   Sun Jun 19 19:02:41 2016 +1000

    Don't re-hlighlight search matches on search string change.
    
    Since the search folder will cause a re-fetch on search when the search
    query has changed such that the results have also changed, the fetch will
    launch a highlight search and we don't also need to launch it again when
    the search terms have changed. This saves potentially a lot of DB query
    time.
    
    * src/client/conversation-viewer/conversation-viewer.vala
      (ConversationViewer): Remove on_search_text_changed and its callers.

 .../conversation-viewer/conversation-viewer.vala   |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
---
diff --git a/src/client/conversation-viewer/conversation-viewer.vala 
b/src/client/conversation-viewer/conversation-viewer.vala
index 2d2fb9e..a573a7b 100644
--- a/src/client/conversation-viewer/conversation-viewer.vala
+++ b/src/client/conversation-viewer/conversation-viewer.vala
@@ -532,11 +532,6 @@ public class ConversationViewer : Gtk.Box {
         }
     }
     
-    private void on_search_text_changed(Geary.SearchQuery? query) {
-        if (query != null)
-            highlight_search_terms.begin();
-    }
-    
     // This applies a fudge-factor set of matches when the database results
     // aren't entirely satisfactory, such as when you search for an email
     // address and the database tokenizes out the @ and ., etc.  It's not meant
@@ -2439,7 +2434,6 @@ public class ConversationViewer : Gtk.Box {
         web_view.unmark_text_matches();
         
         if (search_folder != null) {
-            search_folder.search_query_changed.disconnect(on_search_text_changed);
             search_folder = null;
         }
         
@@ -2477,7 +2471,6 @@ public class ConversationViewer : Gtk.Box {
     private uint on_enter_search_folder(uint state, uint event, void *user, Object? object) {
         search_folder = current_folder as Geary.SearchFolder;
         assert(search_folder != null);
-        search_folder.search_query_changed.connect(on_search_text_changed);
         
         return SearchState.SEARCH_FOLDER;
     }