[polari] userList: Use GtkScrolledWindow:max-content-height
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [polari] userList: Use GtkScrolledWindow:max-content-height
- Date: Thu, 16 Jun 2016 10:02:53 +0000 (UTC)
commit aa023a8c3c2b84705b91535f08795ccd3954aef4
Author: Florian Müllner <fmuellner gnome org>
Date: Thu Jun 16 10:55:22 2016 +0200
userList: Use GtkScrolledWindow:max-content-height
Since commit 025ec4172166, we don't expand the user list popover
indefinitely, but limit its height to eight members. This is currently
implemented by not expanding the popover and setting a minimum height
on the content.
GTK+ recently introduced a GtkScrolledWindow:max-content-height property
that unfortunately broke our code, as the popover ends up being expanded
again. However using the new :max-content-height fixes the issue and
reflects the intention of the code better anyway, so just do that.
src/userList.js | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/userList.js b/src/userList.js
index d5bd1b0..6009c1d 100644
--- a/src/userList.js
+++ b/src/userList.js
@@ -469,7 +469,7 @@ const UserList = new Lang.Class({
for (let i = 0; i < membersShown; i++)
height += this._list.get_row_at_index(index + i).get_allocated_height();
- this.min_content_height = height;
+ this.max_content_height = height;
this._updateHeightId = 0;
return GLib.SOURCE_REMOVE;
}));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]