[gnome-software] trivial: Do not continue to run authentication plugin vfuncs on error

[Richard Hughes <rhughes src gnome org>]

commit 8936728dc304452533ac120061688c9871826460
Author: Richard Hughes <richard hughsie com>
Date:   Fri Jun 10 17:34:58 2016 +0100

    trivial: Do not continue to run authentication plugin vfuncs on error
    
    They're expected to fail with useful data, so don't throw it away.

 src/gs-plugin-loader.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/src/gs-plugin-loader.c b/src/gs-plugin-loader.c
index cd41233..854ad53 100644
--- a/src/gs-plugin-loader.c
+++ b/src/gs-plugin-loader.c
@@ -3174,11 +3174,11 @@ gs_plugin_loader_auth_action_thread_cb (GTask *task,
                                            state->function_name);
                                continue;
                        }
-                       g_warning ("failed to call %s on %s: %s",
-                                  state->function_name,
-                                  gs_plugin_get_name (plugin),
-                                  error_local->message);
-                       continue;
+
+                       /* stop running other plugins on failure */
+                       g_task_return_error (task, error_local);
+                       error_local = NULL;
+                       return;
                }
                gs_plugin_status_update (plugin, NULL, GS_PLUGIN_STATUS_FINISHED);
        }